[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2887: fix: connection saving must return after 2 seconds even though the ne…

[GitBox <gi...@apache.org>]

likyh commented on code in PR #2887:
URL: https://github.com/apache/incubator-devlake/pull/2887#discussion_r959530269


##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -282,7 +285,11 @@ function useConnectionManager (
         if (!updateMode) {
           history.push(`/integrations/${provider.id}`)
         }
-      } else {
+      }
+    })
+
+    setTimeout(() => {

Review Comment:
   > Have you had a chance to evaluate the last comment by chaining a `.catch(e => Toast......)` to the savePromise and see if that removes the need for using the timeout?
   
   This change will lead to waiting most of 30 seconds or more. So I haven't changed it. If we can accept this, we can submit another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org