[GitHub] [apisix] bzp2010 commented on a diff in pull request #9037: feat: bump lua-resty-ldap version for ldap-auth

["bzp2010 (via GitHub)" <gi...@apache.org>]

bzp2010 commented on code in PR #9037:
URL: https://github.com/apache/apisix/pull/9037#discussion_r1134811874


##########
ci/common.sh:
##########
@@ -56,6 +56,19 @@ rerun_flaky_tests() {
     FLUSH_ETCD=1 prove --timer -I./test-nginx/lib -I./ $(echo "$tests" | xargs)
 }
 
+install_curl () {
+    wget https://curl.se/download/curl-7.88.0.tar.gz

Review Comment:
   Yes, it makes sense, fixed.



##########
apisix/plugins/ldap-auth.lua:
##########
@@ -100,6 +100,11 @@ local function extract_auth_header(authorization)
 end
 
 function _M.rewrite(conf, ctx)
+    if not ok then -- ensure rasn library loaded

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org