[GitHub] [airflow] jedcunningham commented on a change in pull request #22041: Fix/21994 liveness probe

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #22041:
URL: https://github.com/apache/airflow/pull/22041#discussion_r820907985



##########
File path: chart/Chart.yaml
##########
@@ -19,7 +19,7 @@
 ---
 apiVersion: v2
 name: airflow
-version: 1.5.0-dev
+version: 1.5.1-dev

Review comment:
       Yeah, we don't need to touch this here.

##########
File path: chart/values.schema.json
##########
@@ -1504,6 +1504,20 @@
                             "description": "How often (in seconds) to perform the probe. Minimum value is 1.",
                             "type": "integer",
                             "default": 60
+                        },
+                        "exec": {
+                            "description": "Custom exec command for livenessProbe",

Review comment:
       ```suggestion
                               "description": "Command for livenessProbe",
   ```
   
   I'm also not sure we need to maintain the nesting of `exec.command`. I'd rather we flatten it and just have `livenessProbe.command`. My 2c, thoughts?

##########
File path: chart/values.yaml
##########
@@ -563,6 +563,24 @@ scheduler:
     timeoutSeconds: 20
     failureThreshold: 5
     periodSeconds: 60
+    exec:
+      command:
+        - sh
+        - -c
+        - |
+          CONNECTION_CHECK_MAX_COUNT=0 /entrypoint python -Wignore -c "

Review comment:
       ```suggestion
             CONNECTION_CHECK_MAX_COUNT=0 exec /entrypoint python -Wignore -c "
   ```
   
   This is where the exec should be, and I think we want to keep it so `timeoutSeconds` can actually function.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org