[PR] fix(dashboard): show dashboard thumbnail images when retrieved [superset]

["rad-pat (via GitHub)" <gi...@apache.org>]

rad-pat opened a new pull request, #33726:
URL: https://github.com/apache/superset/pull/33726

   ### SUMMARY
   Fixes https://github.com/apache/superset/issues/30287, dashboard thumbnails not showing on dashboards list.
   
   Change https://github.com/apache/superset/pull/28609 introduced useEffect to evaluate each dashboard thumbnailUrl separately from the list retrieval to improve performance. The result of the retrieval was never applied to the imgURL so thumbnails were no longer requested.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Enable thumbnail generation and navigate to the dashboards list to view thumbnails
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/superset/issues/30287
   - [x] Required feature flags: THUMBNAILS, THUMBNAILS_SQLA_LISTENERS
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): show dashboard thumbnail images when retrieved [superset]

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina merged PR #33726:
URL: https://github.com/apache/superset/pull/33726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org