You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/18 16:32:24 UTC

[GitHub] [tvm] tqchen commented on a diff in pull request #13791: [TOOL][NATIVE] Android native application for deploy and run

tqchen commented on code in PR #13791:
URL: https://github.com/apache/tvm/pull/13791#discussion_r1073772649


##########
.gitmodules:
##########
@@ -19,3 +19,6 @@
 [submodule "3rdparty/OpenCL-Headers"]
 	path = 3rdparty/OpenCL-Headers
 	url = https://github.com/KhronosGroup/OpenCL-Headers.git
+[submodule "3rdparty/cnpy"]
+	path = 3rdparty/cnpy
+	url = https://github.com/rogersce/cnpy.git

Review Comment:
   Personally I still think having an util to be able to create such a dump can be helpful. Mainly because the numpy format can be complicated and there will be questions of supporting other formats, such as protobuf. So converting to a standard one that we commonly use can be better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org