You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by gadLinux <gi...@git.apache.org> on 2016/03/05 01:28:56 UTC
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
GitHub user gadLinux opened a pull request:
https://github.com/apache/thrift/pull/921
THRIFT-3706 : Implement protocol multiplexor in c_glib
This patch implements protocol multiplexor for the client. For the server there's a need for a processor that currently we don't have. So a test of this can only be tested against other language that already has this in place. We did testing against Java.
Example of use:
/*
* We will use binary encoding
*/
ThriftBinaryProtocol *binary_protocol= g_object_new (THRIFT_TYPE_BINARY_PROTOCOL,
"transport", manager->transport,
NULL);
/*
* FIXME Transport in the multiplexed should be got from binary_protocol
*/
ThriftMultiplexedProtocol *multiplexed_protocol= g_object_new (THRIFT_TYPE_MULTIPLEXED_PROTOCOL,
"transport", manager->transport,
"protocol", binary_protocol,
"service-name", "MyService",
NULL);
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gadLinux/thrift thrift-3706
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #921
----
commit b02c04273338c70f89765664a816b334f22159af
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date: 2016-03-04T12:16:22Z
Implement multiplexed protocol
commit 2bb338c6e96abdc0bf0020e83ad7b1e76f29d43e
Author: Gonzalo Aguilar Delgado <ga...@level2crm.com>
Date: 2016-03-05T00:21:27Z
Implement protocol multiplexor. For me there are a pair of things missing.
Implement protocol decorator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the pull request:
https://github.com/apache/thrift/pull/921#issuecomment-193277215
Hi,
It's done in another pull request.
El 05/03/16 a las 05:47, Aki Sukegawa escribió:
>
> @gadLinux <https://github.com/gadLinux> could you rebase this to the
> current master ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/thrift/pull/921#issuecomment-192568249>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the pull request:
https://github.com/apache/thrift/pull/921#issuecomment-192871461
I will redo it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux closed the pull request at:
https://github.com/apache/thrift/pull/921
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the pull request:
https://github.com/apache/thrift/pull/921#issuecomment-193278780
Please use this one.
https://github.com/apache/thrift/pull/927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/921#issuecomment-192568249
@gadLinux could you rebase this to the current master ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3706 : Implement protocol multiplexor ...
Posted by gadLinux <gi...@git.apache.org>.
Github user gadLinux commented on the pull request:
https://github.com/apache/thrift/pull/921#issuecomment-192871257
Sorry forget about this I screwed it up
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---