You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2010/11/13 13:18:14 UTC
[jira] Resolved: (WICKET-3161) Can not create cookies
[ https://issues.apache.org/jira/browse/WICKET-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl resolved WICKET-3161.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
I am confident that this issue is fixed but I am not very happy about the solution. Please feel free to improve it or send me feedback.
I also added a test case in wicket source to test for existance of cookies that were set during a link listener event.
General question to wicket devs: Is it ok to "resolve issue" if I am not happy with a solution but the issue is fixed?
> Can not create cookies
> ----------------------
>
> Key: WICKET-3161
> URL: https://issues.apache.org/jira/browse/WICKET-3161
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M3
> Environment: Windows 7, Intel i7
> Reporter: Ivaylo Stoykov
> Assignee: Peter Ertl
> Fix For: 1.5-M4
>
> Attachments: quickstart.zip
>
>
> Hi,
> I'm migrating to wicket 1.5-M3 and I've encountered a problem. I can not create cookies (I presume that I can't delete them either).
> I've looked through the source code and this is what I found:
> I add the cookie to the response and I end up with a nice HeaderBufferingWebResponse which contains BufferedWebResponse$AddCookieAction.
> But then redirectTo(Url, RequestCycle) from WebPageRenderer class is called. Here is the method:
>
> private void redirectTo(Url url, RequestCycle requestCycle)
> {
> WebResponse response = (WebResponse)requestCycle.getResponse();
> String relativeUrl = requestCycle.getUrlRenderer().renderUrl(url);
> response.reset();
> response.sendRedirect(relativeUrl);
> }
> response.reset(); - removes all actions from the request.
> So after this method my request has got only BufferedWebResponse$SendRedirectAction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (WICKET-3161) Can not create cookies
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Nov 16, 2010 at 3:10 AM, Jeremy Thomerson <jr...@apache.org>wrote:
>
>
> On Sat, Nov 13, 2010 at 7:18 AM, Peter Ertl (JIRA) <ji...@apache.org>wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/WICKET-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>>
>> Peter Ertl resolved WICKET-3161.
>> --------------------------------
>>
>> Resolution: Fixed
>> Fix Version/s: 1.5-M4
>>
>> I am confident that this issue is fixed but I am not very happy about the
>> solution. Please feel free to improve it or send me feedback.
>>
>> I also added a test case in wicket source to test for existance of cookies
>> that were set during a link listener event.
>>
>> General question to wicket devs: Is it ok to "resolve issue" if I am not
>> happy with a solution but the issue is fixed?
>
>
> I don't see why not, although if you're really dissatisfied with the
> solution, you may want to open a follow-up ticket to clean up the solution.
>
>
> Jeremy
>
>>
>
> My approach in such cases is to attach a patch and ask for review.
martin-g
Re: [jira] Resolved: (WICKET-3161) Can not create cookies
Posted by Jeremy Thomerson <jr...@apache.org>.
On Sat, Nov 13, 2010 at 7:18 AM, Peter Ertl (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/WICKET-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Peter Ertl resolved WICKET-3161.
> --------------------------------
>
> Resolution: Fixed
> Fix Version/s: 1.5-M4
>
> I am confident that this issue is fixed but I am not very happy about the
> solution. Please feel free to improve it or send me feedback.
>
> I also added a test case in wicket source to test for existance of cookies
> that were set during a link listener event.
>
> General question to wicket devs: Is it ok to "resolve issue" if I am not
> happy with a solution but the issue is fixed?
I don't see why not, although if you're really dissatisfied with the
solution, you may want to open a follow-up ticket to clean up the solution.
Jeremy
>