You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/24 01:49:31 UTC

[GitHub] [hudi] alexeykudinkin opened a new pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

alexeykudinkin opened a new pull request #4091:
URL: https://github.com/apache/hudi/pull/4091


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   When doing `commits showarchived` in CLI it fails if REPLACE_COMMIT is present in the archived Timeline:
   
   ```
   hudi:hoodie_benchmark->commits showarchived 5993625 [Spring Shell] ERROR org.springframework.shell.core.SimpleExecutionStrategy - Command failed org.apache.hudi.exception.HoodieIOException: Unknown action in metadata replacecommit 5993625 [Spring Shell] WARN org.springframework.shell.core.JLineShellComponent.exceptions - Unknown action in metadata replacecommit org.apache.hudi.exception.HoodieIOException: Unknown action in metadata replacecommit
   ```
   
   ## Brief change log
   
    - Fixed archived Metadata Timeline to support REPLACE_COMMIT action
    - Make sure no exception is thrown in case we couldn't extract Metadata for the given Commit type
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yihua commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978458032


   > @vinothchandar @yihua i've taken a look and it won't be a simple enhancement of the test since state is constructed manually in (`TestCommitsCommand`), so i would essentially need to replicate this test for REPLACE_COMMIT.
   > 
   > I do think that we should add tests for all types of commits that we have, but that would be much larger change.
   
   Got it.  Let's create a ticket for adding the tests in a separate non-release-blocker PR.  I'll merge this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978291265


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710",
       "triggerID" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   * d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978286393


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   * d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977398940


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977453842


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978475574


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710",
       "triggerID" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977391499


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977535262


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yihua commented on a change in pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#discussion_r756215246



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -173,8 +174,11 @@ private String getMetadataKey(String action) {
         return "hoodieSavePointMetadata";
       case HoodieTimeline.COMPACTION_ACTION:
         return "hoodieCompactionPlan";
+      case HoodieTimeline.REPLACE_COMMIT_ACTION:
+        return "hoodieReplaceCommitMetadata";

Review comment:
       Possible to tweak existing tests to consider the clustering commit?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] alexeykudinkin commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978285269


   @vinothchandar @yihua i've taken a look and it won't be a simple enhancement of the test since state is constructed manually in (`TestCommitsCommand`), so i would essentially need to replicate this test for REPLACE_COMMIT.
   
   I do think that we should add tests for all types of commits that we have, but that would be much larger change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yihua merged pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
yihua merged pull request #4091:
URL: https://github.com/apache/hudi/pull/4091


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977398940


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] vinothchandar commented on a change in pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#discussion_r756343584



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -173,8 +174,11 @@ private String getMetadataKey(String action) {
         return "hoodieSavePointMetadata";
       case HoodieTimeline.COMPACTION_ACTION:
         return "hoodieCompactionPlan";
+      case HoodieTimeline.REPLACE_COMMIT_ACTION:
+        return "hoodieReplaceCommitMetadata";
       default:
-        throw new HoodieIOException("Unknown action in metadata " + action);
+        LOG.error(String.format("Unknown action in metadata (%s)", action));
+        return null;

Review comment:
       Can we return an Option instead of null

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -173,8 +174,11 @@ private String getMetadataKey(String action) {
         return "hoodieSavePointMetadata";
       case HoodieTimeline.COMPACTION_ACTION:
         return "hoodieCompactionPlan";
+      case HoodieTimeline.REPLACE_COMMIT_ACTION:
+        return "hoodieReplaceCommitMetadata";

Review comment:
       yeah adding an `insert_overwrite` operation would also generate a replacecommit. don't even need clustering




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977391499


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977392513


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978286393


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   * d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-978291265


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710",
       "triggerID" : "d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   * d2d7a9746de07ffa9c490cf88f86b04a5f73b8ad Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3710) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977392513


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977397657


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977397657


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977453842


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0260bd53a3ea05d0e8c2024c84c15b100e64fe5d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656) 
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4091: [HUDI-2844][CLI] Fixing archived Timeline crashing if timeline contains REPLACE_COMMIT

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4091:
URL: https://github.com/apache/hudi/pull/4091#issuecomment-977535262


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3656",
       "triggerID" : "0260bd53a3ea05d0e8c2024c84c15b100e64fe5d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664",
       "triggerID" : "bb7ddb58721bb6837eb73c90c1a0f44f31c98065",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bb7ddb58721bb6837eb73c90c1a0f44f31c98065 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3664) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org