You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/04/09 06:34:32 UTC

Review Request 66500: ATLAS-2538 : UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66500/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2538
    https://issues.apache.org/jira/browse/ATLAS-2538


Repository: atlas


Description
-------

When classifications are searched from "Classifications" Tab , the result layout has "Exclude sub-types" check box which is not required . Only "Exclude sub-classifications" and "Show historical entities" check boxes should be good enough.


Diffs
-----

  dashboardv2/public/js/modules/Helpers.js 3897d58 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html fb9481a 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js dc4f49a 


Diff: https://reviews.apache.org/r/66500/diff/1/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey

Re: Review Request 66500: ATLAS-2538 : UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66500/#review201036
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 9, 2018, 6:34 a.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66500/
> -----------------------------------------------------------
> 
> (Updated April 9, 2018, 6:34 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2538
>     https://issues.apache.org/jira/browse/ATLAS-2538
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When classifications are searched from "Classifications" Tab , the result layout has "Exclude sub-types" check box which is not required . Only "Exclude sub-classifications" and "Show historical entities" check boxes should be good enough.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/modules/Helpers.js 3897d58 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html fb9481a 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js dc4f49a 
> 
> 
> Diff: https://reviews.apache.org/r/66500/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>