You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by "Galbreath, Mark" <Ga...@tessco.com> on 2002/04/09 15:36:09 UTC
Re: Stephan's Struts Tutorial
A few constructive comments, Stephan for the first 5 chapters:
1. Clean up your spelling and grammar (e.g., "then," not "than");
2. It's "TLD," not "LTD;"
3. You should use an ArrayList() instead of a Vector() for your authors
list
because everything is (should be) in session scope, there is no need for
synchronization;
4. IMHO, it's less than ideal practice to import blindly (e.g.,
"java.util.*"),
especially in a tutorial.
5. ActionForm.perform() has been deprecated - use ActionForm.execute()
instead;
6. Your JavaDoc @param for "req" and "res" is incorrect;
7. You should comment that your "System.out.println()"s will be written to
the container's log (newbies do not realize this);
I'll look at the rest later...gotta get back to work! Overall, a
much-needed tutorial.
Mark