You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/04/23 00:27:30 UTC

[GitHub] zeppelin pull request #2937: ZEPPELIN-3401. Deadlock while restarting interp...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2937

    ZEPPELIN-3401. Deadlock while restarting interpreter

    ### What is this PR for?
    A few sentences describing the overall goals of the pull request's commits.
    First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
    
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3401

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2937
    
----
commit 5ffcc11a4bce8f69d911fb700c90d2aeddbad8e7
Author: Jeff Zhang <zj...@...>
Date:   2018-04-22T03:46:53Z

    ZEPPELIN-3401. Deadlock while restarting interpreter

----


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    so far no more issues. LGTM :+1: 


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    Today we had that bug again (seems to occur daily) without the patch added to PROD.
    Now just added the patch to PROD. Will wait another 48h from now before I tell you that it's working.


---

[GitHub] zeppelin pull request #2937: ZEPPELIN-3401. Deadlock while restarting interp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2937


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    IMHO, it would be better to use [ReentrantReadWriteLock](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantReadWriteLock.html). What do you think of it?


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    It is just used in 2 places, synchronized should be fine. ReadWriteLock is more suitable for the scenario of many reads & a few write


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    \cc @weand 


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2937
  
    Thanks for verifying it, @weand 


---