[GitHub] leventov commented on a change in pull request #6971: Added checkstyle for "Methods starting with Capital Letters"

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6971: Added checkstyle for "Methods starting with Capital Letters" 
URL: https://github.com/apache/incubator-druid/pull/6971#discussion_r253423013
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
 ##########
 @@ -133,15 +133,15 @@ public void testSelectCountStart() throws Exception
         CalciteTests.REGULAR_USER_AUTH_RESULT,
         ImmutableList.of(Druids.newTimeseriesQueryBuilder()
                                .dataSource(CalciteTests.DATASOURCE1)
-                               .intervals(QSS(Filtration.eternity()))
-                               .filters(SELECTOR("dim2", "0", null))
+                               .intervals(qss(Filtration.eternity()))
 
 Review comment:
   @clintropolis in my opinion, methods names that are acronyms is a bad idea. I think better to expand them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org