You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by ba...@apache.org on 2023/02/20 08:53:55 UTC

[pulsar-client-cpp] branch main updated: Fix broken main branch that failed to build the wireshark dissector on macOS (#199)

This is an automated email from the ASF dual-hosted git repository.

baodi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git


The following commit(s) were added to refs/heads/main by this push:
     new f55b4bd  Fix broken main branch that failed to build the wireshark dissector on macOS (#199)
f55b4bd is described below

commit f55b4bd0f57811e54abc0603bf9dc174bbaef389
Author: Yunze Xu <xy...@163.com>
AuthorDate: Mon Feb 20 16:53:50 2023 +0800

    Fix broken main branch that failed to build the wireshark dissector on macOS (#199)
    
    ### Motivation
    
    https://github.com/apache/pulsar-client-cpp/actions/runs/4220713571/jobs/7327254536
    
    It failed because `pkg-config` is not installed by default after the
    upgrade of `macos-12` GitHub runner image.
    
    ### Modifications
    
    Install the `pkg-config` dependency.
---
 .github/workflows/ci-pr-validation.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci-pr-validation.yaml b/.github/workflows/ci-pr-validation.yaml
index 67ce86f..af7dd8a 100644
--- a/.github/workflows/ci-pr-validation.yaml
+++ b/.github/workflows/ci-pr-validation.yaml
@@ -50,7 +50,7 @@ jobs:
       - name: Install deps (macOS)
         if: ${{ startsWith(matrix.os, 'macos') }}
         run:
-          brew install wireshark protobuf
+          brew install pkg-config wireshark protobuf
 
       - name: Build wireshark plugin
         run: |