You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Andor Molnar (JIRA)" <ji...@apache.org> on 2018/03/06 14:31:00 UTC
[jira] [Commented] (ZOOKEEPER-2993) .ignore file prevents adding
src/java/main/org/apache/jute/compiler/generated dir to git repo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387863#comment-16387863 ]
Andor Molnar commented on ZOOKEEPER-2993:
-----------------------------------------
[~taoist]
Nice catch, thanks for creating the Jira.
I think the name of the directory (generated) is a little bit misleading, because these files are part of the codebase since the very beginning and have mistakenly put on ignore by [~cnauroth] in [https://github.com/apache/zookeeper/commit/fa5955afa0962147268241163b7ca47dcdd074e0]
Are you happy to contribute and file a new PR on GitHub to address the issue as suggested?
> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to git repo
> ---------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.4.10
> Reporter: jason wang
> Priority: Minor
>
> There are Rcc.java and other required files under the src/java/main/org/apache/jute/compiler/generated directory.
> However, when I tried to add the source distribution to our own git repo, the .gitignore file has "generated" as a key word in line 55 - which prevents the dir and files under that dir to be added to the repo. The compilation later fails due to the missing dir and files.
> *compile_jute*
> :*19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>
> Fix is to remove or comment out the generated key word in line 55.
> #
> #generated
> #
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)