You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/07/18 10:06:31 UTC
svn commit: r1891643 -
/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java
Author: tilman
Date: Sun Jul 18 10:06:30 2021
New Revision: 1891643
URL: http://svn.apache.org/viewvc?rev=1891643&view=rev
Log:
PDFBOX-4892: simplify code, as suggested by valerybokov
Modified:
pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java
Modified: pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java?rev=1891643&r1=1891642&r2=1891643&view=diff
==============================================================================
--- pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java (original)
+++ pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/graphic/StandardColorSpaceHelper.java Sun Jul 18 10:06:30 2021
@@ -30,6 +30,7 @@ import java.util.Objects;
import org.apache.pdfbox.cos.COSArray;
import org.apache.pdfbox.cos.COSBase;
import org.apache.pdfbox.cos.COSDictionary;
+import org.apache.pdfbox.cos.COSInteger;
import org.apache.pdfbox.cos.COSName;
import org.apache.pdfbox.cos.COSNumber;
import org.apache.pdfbox.cos.COSStream;
@@ -513,15 +514,14 @@ public class StandardColorSpaceHelper im
private boolean validateICCProfileNEntry(COSStream stream, ICC_Profile iccp)
{
- COSDictionary streamDict = (COSDictionary) stream.getCOSObject();
- if (!streamDict.containsKey(COSName.N))
+ COSBase nValue = stream.getItem(COSName.N);
+ if (nValue == null)
{
context.addValidationError(new ValidationError(ERROR_GRAPHIC_OUTPUT_INTENT_INVALID_ENTRY,
"/N entry of ICC profile is mandatory"));
return false;
}
- COSBase nValue = streamDict.getItem(COSName.N);
- if (!(nValue instanceof COSNumber))
+ if (!(nValue instanceof COSInteger))
{
context.addValidationError(new ValidationError(ERROR_GRAPHIC_OUTPUT_INTENT_INVALID_ENTRY,
"/N entry of ICC profile must be a number, but is " + nValue));