[GitHub] metamodel pull request: METAMODEL-244: Added support for Excel dat...

[LosD <gi...@git.apache.org>]

Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/99#discussion_r63100757
  
    --- Diff: couchdb/src/test/java/org/apache/metamodel/couchdb/CouchDbDataContextTest.java ---
    @@ -53,7 +53,8 @@ protected void setUp() throws Exception {
             super.setUp();
     
             if (isConfigured()) {
    -            httpClient = new StdHttpClient.Builder().host(getHostname()).build();
    +            final int timeout = 8 * 1000; // 8 seconds should be more than enough
    --- End diff --
    
    `public static final SOCKET_TIMEOUT`?
    
    (I have a great hate for socket timeout settings, because they always seems so arbitrary, and it's hard to find a good number, especially in our case where we really don't know what the use case will be... I guess that's a sign that we at some point should make these user configurable)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---