You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/02 18:53:20 UTC
Re: Review Request 53888: Improved
SlaveRecoveryTest.ReconcileShutdownFramework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53888/#review157790
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/slave_recovery_tests.cpp (line 3089)
<https://reviews.apache.org/r/53888/#comment228394>
s/first/completed/
src/tests/slave_recovery_tests.cpp (line 3101)
<https://reviews.apache.org/r/53888/#comment228395>
s/first/completed/
- Vinod Kone
On Nov. 29, 2016, 12:26 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53888/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 12:26 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6419
> https://issues.apache.org/jira/browse/MESOS-6419
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Check the output of the "/state" endpoint to confirm that the framework
> has been shutdown properly and the task has been marked as killed.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 3b7d8cf9600496d2e7f5105e4f561e914c54a36a
>
> Diff: https://reviews.apache.org/r/53888/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>