You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@chukwa.apache.org by as...@apache.org on 2009/08/04 06:35:39 UTC
svn commit: r800673 - in /hadoop/chukwa/trunk: CHANGES.txt
src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java
Author: asrabkin
Date: Tue Aug 4 04:35:39 2009
New Revision: 800673
URL: http://svn.apache.org/viewvc?rev=800673&view=rev
Log:
CHUKWA-74. Agent shouldn't log exceptions for down collectors. Contributed by Rushin Barot
Modified:
hadoop/chukwa/trunk/CHANGES.txt
hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java
Modified: hadoop/chukwa/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/CHANGES.txt?rev=800673&r1=800672&r2=800673&view=diff
==============================================================================
--- hadoop/chukwa/trunk/CHANGES.txt (original)
+++ hadoop/chukwa/trunk/CHANGES.txt Tue Aug 4 04:35:39 2009
@@ -44,6 +44,8 @@
IMPROVEMENTS
+ CHUKWA-74. Agent shouldn't log exceptions for down collectors. (Rushin Barot via asrabkin)
+
CHUKWA-365. Improved DumpArchive tool. (asrabkin)
CHUKWA-364. Design and Architecture document in documentation. (asrabkin)
Modified: hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java
URL: http://svn.apache.org/viewvc/hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java?rev=800673&r1=800672&r2=800673&view=diff
==============================================================================
--- hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java (original)
+++ hadoop/chukwa/trunk/src/java/org/apache/hadoop/chukwa/datacollection/sender/ChukwaHttpSender.java Tue Aug 4 04:35:39 2009
@@ -153,8 +153,7 @@
if (collectors.hasNext()) {
currCollector = collectors.next();
} else
- log
- .error("No collectors to try in send(), not even trying to do doPost()");
+ log.error("No collectors to try in send(), not even trying to do doPost()");
}
}
@@ -203,16 +202,15 @@
// sent
return commitResults;
} catch (Throwable e) {
- log.error("Http post exception", e);
+ log.error("Http post exception");
+ log.debug("Http post exception", e);
ChukwaHttpSender.metrics.httpThrowable.inc();
- log
- .info("Checking list of collectors to see if another collector has been specified for rollover");
+ log.info("Checking list of collectors to see if another collector has been specified for rollover");
if (collectors.hasNext()) {
ChukwaHttpSender.metrics.collectorRollover.inc();
currCollector = collectors.next();
- log
- .info("Found a new collector to roll over to, retrying HTTP Post to collector "
+ log.info("Found a new collector to roll over to, retrying HTTP Post to collector "
+ currCollector);
} else {
if (retries > 0) {
@@ -279,8 +277,7 @@
throw new HttpException("got back a failure from server");
}
// implicitly "else"
- log
- .info(">>>>>> HTTP Got success back from the remote collector; response length "
+ log.info(">>>>>> HTTP Got success back from the remote collector; response length "
+ method.getResponseContentLength());
// FIXME: should parse acks here