You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by rekhajoshm <gi...@git.apache.org> on 2016/05/16 22:19:26 UTC

[GitHub] flink pull request: [FLINK-3782] ByteArrayOutputStream and ObjectO...

GitHub user rekhajoshm opened a pull request:

    https://github.com/apache/flink/pull/1995

    [FLINK-3782] ByteArrayOutputStream and ObjectOutputStream should close

    [FLINK-3782] ByteArrayOutputStream and ObjectOutputStream should close
    
    The ByteArrayOutputStream close method is useless and has no impact, so is usually never called.However I am using try with resources for both to take care of closing closeable resources automatically.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rekhajoshm/flink FLINK-3782

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1995
    
----
commit 2fec41be0f1ef8f1b9f707d0085d6f9fca8101bb
Author: Joshi <re...@gmail.com>
Date:   2016-05-16T22:18:42Z

    [FLINK-3782] ByteArrayOutputStream and ObjectOutputStream should close

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3782] ByteArrayOutputStream and ObjectO...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1995


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3782] ByteArrayOutputStream and ObjectO...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1995#issuecomment-219639748
  
    The change looks good. +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3782] ByteArrayOutputStream and ObjectO...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1995#issuecomment-219806248
  
    Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3782] ByteArrayOutputStream and ObjectO...

Posted by rekhajoshm <gi...@git.apache.org>.

Github user rekhajoshm commented on the pull request:

    https://github.com/apache/flink/pull/1995#issuecomment-219808609
  
    thanks @StephanEwen @rmetzger 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---