You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-commits@hadoop.apache.org by cn...@apache.org on 2014/04/19 06:07:23 UTC
svn commit: r1588605 - in /hadoop/common/trunk/hadoop-mapreduce-project:
CHANGES.txt
hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java
Author: cnauroth
Date: Sat Apr 19 04:07:22 2014
New Revision: 1588605
URL: http://svn.apache.org/r1588605
Log:
MAPREDUCE-5642. TestMiniMRChildTask fails on Windows. Contributed by Chuan Liu.
Modified:
hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java
Modified: hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt?rev=1588605&r1=1588604&r2=1588605&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt Sat Apr 19 04:07:22 2014
@@ -180,6 +180,9 @@ Release 2.5.0 - UNRELEASED
MAPREDUCE-4937. MR AM handles an oversized split metainfo file poorly
(Eric Payne via jlowe)
+ MAPREDUCE-5642. TestMiniMRChildTask fails on Windows.
+ (Chuan Liu via cnauroth)
+
Release 2.4.1 - UNRELEASED
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java?rev=1588605&r1=1588604&r2=1588605&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java (original)
+++ hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestMiniMRChildTask.java Sat Apr 19 04:07:22 2014
@@ -254,6 +254,19 @@ public class TestMiniMRChildTask {
checkEnv("NEW_PATH", File.pathSeparator + "/tmp", "noappend");
// check if X=$(tt's X var):/tmp for an old env variable inherited from
// the tt
+ if (Shell.WINDOWS) {
+ // On Windows, PATH is replaced one more time as part of default config
+ // of "mapreduce.admin.user.env", i.e. on Windows,
+ // "mapreduce.admin.user.env" is set to
+ // "PATH=%PATH%;%HADOOP_COMMON_HOME%\\bin"
+ String hadoopHome = System.getenv("HADOOP_COMMON_HOME");
+ if (hadoopHome == null) {
+ hadoopHome = "";
+ }
+ String hadoopLibLocation = hadoopHome + "\\bin";
+ path += File.pathSeparator + hadoopLibLocation;
+ path += File.pathSeparator + path;
+ }
checkEnv("PATH", path + File.pathSeparator + "/tmp", "noappend");
String jobLocalDir = job.get(MRJobConfig.JOB_LOCAL_DIR);
@@ -308,6 +321,19 @@ public class TestMiniMRChildTask {
checkEnv("NEW_PATH", File.pathSeparator + "/tmp", "noappend");
// check if X=$(tt's X var):/tmp for an old env variable inherited from
// the tt
+ if (Shell.WINDOWS) {
+ // On Windows, PATH is replaced one more time as part of default config
+ // of "mapreduce.admin.user.env", i.e. on Windows,
+ // "mapreduce.admin.user.env"
+ // is set to "PATH=%PATH%;%HADOOP_COMMON_HOME%\\bin"
+ String hadoopHome = System.getenv("HADOOP_COMMON_HOME");
+ if (hadoopHome == null) {
+ hadoopHome = "";
+ }
+ String hadoopLibLocation = hadoopHome + "\\bin";
+ path += File.pathSeparator + hadoopLibLocation;
+ path += File.pathSeparator + path;
+ }
checkEnv("PATH", path + File.pathSeparator + "/tmp", "noappend");
}