[GitHub] [directory-scimple] bdemers commented on a diff in pull request #240: Allow for InMemoryScimFilterMatcher to traverse maps

["bdemers (via GitHub)" <gi...@apache.org>]

bdemers commented on code in PR #240:
URL: https://github.com/apache/directory-scimple/pull/240#discussion_r1087168547


##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/filter/InMemoryScimFilterMatcher.java:
##########
@@ -87,9 +87,11 @@ protected Predicate<R> unhandledExpression(FilterExpression expression, Attribut
     return scimResource -> false;
   }
 
-  private static abstract class AbstractAttributePredicate<T extends FilterExpression, R> implements Predicate<R> {
+  public <A> A get(Schema.Attribute attribute, A actual) {
+    return attribute.getAccessor().get(actual);
+  }
 
-    private static final Logger log = LoggerFactory.getLogger(InMemoryScimFilterMatcher.class);
+  private abstract class AbstractAttributePredicate<T extends FilterExpression, R> implements Predicate<R> {

Review Comment:
   This diff doesn't render well via github, but it's adding a new method and removing `final` from `AbstractAttributePredicate`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org