You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/09 10:57:56 UTC
[GitHub] [spark] beliefer opened a new pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
beliefer opened a new pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508
### What changes were proposed in this pull request?
The current implement of `regexp_extract` will throws a unprocessed exception show below:
`SELECT regexp_extract('1a 2b 14m', 'd+')`
```
java.lang.IndexOutOfBoundsException: No group 1
[info] at java.util.regex.Matcher.group(Matcher.java:538)
[info] at org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage1.processNext(Unknown Source)
[info] at org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
[info] at org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:729)
```
I think should treat this exception well.
### Why are the changes needed?
Fix a bug `java.lang.IndexOutOfBoundsException No group 1 `
### Does this PR introduce any user-facing change?
Yes
### How was this patch tested?
New UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585036932
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852562
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22863/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584946986
Pending Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918944
**[Test build #118103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118103/testReport)** for PR 27508 at commit [`cc66a32`](https://github.com/apache/spark/commit/cc66a32adf1f735d24067c1ae0560331aa9f1a6e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584949688
**[Test build #118266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118266/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583877835
**[Test build #118098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118098/testReport)** for PR 27508 at commit [`c786471`](https://github.com/apache/spark/commit/c786471ad63d35a9c5c404bcacd2437894182961).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22868/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584611406
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852559
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583844911
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918944
**[Test build #118103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118103/testReport)** for PR 27508 at commit [`cc66a32`](https://github.com/apache/spark/commit/cc66a32adf1f735d24067c1ae0560331aa9f1a6e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-588030529
@gatorsmile OK. Let me take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583844911
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585036934
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118266/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852435
**[Test build #118098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118098/testReport)** for PR 27508 at commit [`c786471`](https://github.com/apache/spark/commit/c786471ad63d35a9c5c404bcacd2437894182961).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584746433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118237/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584611406
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377052956
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
##########
@@ -293,6 +293,27 @@ class RegexpExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
val nonNullExpr = RegExpExtract(Literal("100-200"), Literal("(\\d+)-(\\d+)"), Literal(1))
checkEvaluation(nonNullExpr, "100", row1)
+
+ // invalid group index
+ val row8 = create_row("100-200", "(\\d+)-(\\d+)", 3)
+ val row9 = create_row("100-200", "(\\d+).*", 2)
+ val row10 = create_row("100-200", "\\d+", 1)
+
+ val invalidGroupIndex1 = intercept[AnalysisException] {
+ evaluateWithoutCodegen(expr, row8)
Review comment:
As UT we should test both codegen and non-codegen, let's call `checkEvaluation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583878055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118098/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584259974
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118164/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831633
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377061167
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -524,6 +535,8 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio
$termPattern.matcher($subject.toString());
if ($matcher.find()) {
java.util.regex.MatchResult $matchResult = $matcher.toMatchResult();
+ org.apache.spark.sql.catalyst.expressions.RegExpExtract
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918161
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-588030529
@gatorsmile OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584611415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22997/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583844912
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118094/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r376834921
##########
File path: sql/core/src/test/resources/sql-tests/inputs/regexp-function.sql
##########
@@ -0,0 +1,15 @@
+SELECT regexp_extract('1a 2b 14m', '\\d+');
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 0);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 1);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 2);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)');
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 0);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 1);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 2);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584259091
**[Test build #118164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118164/testReport)** for PR 27508 at commit [`34cf317`](https://github.com/apache/spark/commit/34cf3170019bf21061f6f469d4ba10d81a69f8e2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584128565
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377052340
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -524,6 +535,8 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio
$termPattern.matcher($subject.toString());
if ($matcher.find()) {
java.util.regex.MatchResult $matchResult = $matcher.toMatchResult();
+ org.apache.spark.sql.catalyst.expressions.RegExpExtract
Review comment:
don't hard code the class name. `${classOf[RegExpExtract].getName}.checkGroupIndex`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583961303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118103/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584128565
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377052956
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
##########
@@ -293,6 +293,27 @@ class RegexpExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
val nonNullExpr = RegExpExtract(Literal("100-200"), Literal("(\\d+)-(\\d+)"), Literal(1))
checkEvaluation(nonNullExpr, "100", row1)
+
+ // invalid group index
+ val row8 = create_row("100-200", "(\\d+)-(\\d+)", 3)
+ val row9 = create_row("100-200", "(\\d+).*", 2)
+ val row10 = create_row("100-200", "\\d+", 1)
+
+ val invalidGroupIndex1 = intercept[AnalysisException] {
+ evaluateWithoutCodegen(expr, row8)
Review comment:
As UT we should test both codegen and non-codegen, let's call `checkExceptionInExpression`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584127964
**[Test build #118164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118164/testReport)** for PR 27508 at commit [`34cf317`](https://github.com/apache/spark/commit/34cf3170019bf21061f6f469d4ba10d81a69f8e2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-590597057
It sounds like this is not merged to 3.0. cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585036932
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584949688
**[Test build #118266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118266/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377982764
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -452,6 +452,15 @@ case class RegExpReplace(subject: Expression, regexp: Expression, rep: Expressio
}
}
+object RegExpExtract {
+ def checkGroupIndex(groupCount: Int, groupIndex: Int): Unit = {
+ if (groupCount < groupIndex) {
+ throw new AnalysisException(
Review comment:
Sorry, I missed that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852562
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22863/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584259960
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584950246
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22859/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831635
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22859/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584127964
**[Test build #118164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118164/testReport)** for PR 27508 at commit [`34cf317`](https://github.com/apache/spark/commit/34cf3170019bf21061f6f469d4ba10d81a69f8e2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584745705
**[Test build #118237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118237/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583878049
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r376778344
##########
File path: sql/core/src/test/resources/sql-tests/inputs/regexp-function.sql
##########
@@ -0,0 +1,15 @@
+SELECT regexp_extract('1a 2b 14m', '\\d+');
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 0);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 1);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 2);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)');
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 0);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 1);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 2);
Review comment:
~Can you move these tests into `sql-tests/inputs/string-functions.sql` insteadf of making a new file?~
nvm, my bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831633
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583852435
**[Test build #118098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118098/testReport)** for PR 27508 at commit [`c786471`](https://github.com/apache/spark/commit/c786471ad63d35a9c5c404bcacd2437894182961).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584128580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22925/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584611415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22997/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584259960
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584613554
**[Test build #118237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118237/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584746421
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584746421
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583878055
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118098/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583878049
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583844855
**[Test build #118094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118094/testReport)** for PR 27508 at commit [`9403948`](https://github.com/apache/spark/commit/94039488865d052b796d1ee38a0ca7d2b7702cfe).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584746433
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118237/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585076281
@maropu @cloud-fan @dongjoon-hyun Thanks for all your work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831534
**[Test build #118094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118094/testReport)** for PR 27508 at commit [`9403948`](https://github.com/apache/spark/commit/94039488865d052b796d1ee38a0ca7d2b7702cfe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r376778344
##########
File path: sql/core/src/test/resources/sql-tests/inputs/regexp-function.sql
##########
@@ -0,0 +1,15 @@
+SELECT regexp_extract('1a 2b 14m', '\\d+');
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 0);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 1);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 2);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)');
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 0);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 1);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 2);
Review comment:
Can you move these tests into `sql-tests/inputs/string-functions.sql` insteadf of making a new file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584950256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23025/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377052340
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -524,6 +535,8 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio
$termPattern.matcher($subject.toString());
if ($matcher.find()) {
java.util.regex.MatchResult $matchResult = $matcher.toMatchResult();
+ org.apache.spark.sql.catalyst.expressions.RegExpExtract
Review comment:
don't hard code the class name. `${classOf[RegExpExtract].getName}. checkGroupIndex`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918163
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22868/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583918161
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585036503
**[Test build #118266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118266/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584613554
**[Test build #118237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118237/testReport)** for PR 27508 at commit [`6b960ac`](https://github.com/apache/spark/commit/6b960ac06cba87675a46a7b4ab2ebe80524c5178).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584946899
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584128580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22925/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583831534
**[Test build #118094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118094/testReport)** for PR 27508 at commit [`9403948`](https://github.com/apache/spark/commit/94039488865d052b796d1ee38a0ca7d2b7702cfe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583961303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118103/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584950256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23025/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583961298
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583960825
**[Test build #118103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118103/testReport)** for PR 27508 at commit [`cc66a32`](https://github.com/apache/spark/commit/cc66a32adf1f735d24067c1ae0560331aa9f1a6e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584950246
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585036934
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118266/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585056962
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583844912
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118094/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377061365
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/RegexpExpressionsSuite.scala
##########
@@ -293,6 +293,27 @@ class RegexpExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
val nonNullExpr = RegExpExtract(Literal("100-200"), Literal("(\\d+)-(\\d+)"), Literal(1))
checkEvaluation(nonNullExpr, "100", row1)
+
+ // invalid group index
+ val row8 = create_row("100-200", "(\\d+)-(\\d+)", 3)
+ val row9 = create_row("100-200", "(\\d+).*", 2)
+ val row10 = create_row("100-200", "\\d+", 1)
+
+ val invalidGroupIndex1 = intercept[AnalysisException] {
+ evaluateWithoutCodegen(expr, row8)
Review comment:
Thanks. I know it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377583950
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -452,6 +452,15 @@ case class RegExpReplace(subject: Expression, regexp: Expression, rep: Expressio
}
}
+object RegExpExtract {
+ def checkGroupIndex(groupCount: Int, groupIndex: Int): Unit = {
+ if (groupCount < groupIndex) {
+ throw new AnalysisException(
Review comment:
OK. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-590614681
It seems like that. I locally tested and pushed to `branch-3.0`, too.
- https://github.com/apache/spark/commit/9666cf10aac873ad17e95074da5e1a78c8b64b47
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-584259974
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118164/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-583961298
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27508: [SPARK-30763][SQL] Fix
java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-590660635
seems like my merge script got stuck while I was backporting this PR and I forgot to restore, sorry for the trouble!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r376778344
##########
File path: sql/core/src/test/resources/sql-tests/inputs/regexp-function.sql
##########
@@ -0,0 +1,15 @@
+SELECT regexp_extract('1a 2b 14m', '\\d+');
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 0);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 1);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 2);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)');
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 0);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 1);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 2);
Review comment:
~ Can you move these tests into `sql-tests/inputs/string-functions.sql` insteadf of making a new file? ~
nvm, my bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585056962
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on issue #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-585056962
thanks, merging to master/3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27508: [SPARK-30763][SQL]
Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#issuecomment-587975129
@beliefer Does this problem exist in 2.4? If so, submit a backport PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r377578737
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -452,6 +452,15 @@ case class RegExpReplace(subject: Expression, regexp: Expression, rep: Expressio
}
}
+object RegExpExtract {
+ def checkGroupIndex(groupCount: Int, groupIndex: Int): Unit = {
+ if (groupCount < groupIndex) {
+ throw new AnalysisException(
Review comment:
We do this check at runtime, so `AnalysisException` doesn't fit. How about `IllegalArgumentException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27508:
[SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for
regexp_extract
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract
URL: https://github.com/apache/spark/pull/27508#discussion_r376778520
##########
File path: sql/core/src/test/resources/sql-tests/inputs/regexp-function.sql
##########
@@ -0,0 +1,15 @@
+SELECT regexp_extract('1a 2b 14m', '\\d+');
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 0);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 1);
+
+SELECT regexp_extract('1a 2b 14m', '\\d+', 2);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)');
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 0);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 1);
+
+SELECT regexp_extract('1a 2b 14m', '(\\d+)([a-z]+)', 2);
Review comment:
Also, can you add tests in `RegexpExpressionsSuite`, too , for the non-codegen path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org