You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2011/06/17 01:34:36 UTC

[vote] release 1.5-RC5

This vote is to release wicket 1.5-RC5

Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
Maven repo:
https://repository.apache.org/content/repositories/orgapachewicket-022/
Changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423

This vote ends Thursday, March 19st at 5:00pm (GMT-8)

Please test the release and offer your vote.

The Wicket team!

Re: [vote] release 1.5-RC5

Posted by Igor Vaynberg <ig...@gmail.com>.
The vote has failed with Martijn's -1. Will rebuild soon.

-igor

On Thu, Jun 16, 2011 at 4:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> This vote is to release wicket 1.5-RC5
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-022/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>
> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team!
>

Re: [vote] release 1.5-RC5

Posted by richard emberson <ri...@gmail.com>.
> This vote ends Thursday, March 19st at 5:00pm (GMT-8)

Re: [vote] release 1.5-RC5

Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Jun 17, 2011 at 3:28 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Upgrading from 1.5-RC4.2 to RC5 gives the following API changes...
>
>  - DummyRequestLogger -> RequestLogger
>  - PersistentPageManager -> PageStoreManager
>  - Application#getPageManager() -> Session#getPageManager()
>
>  - FileUploadField#FileUploadField(String, IModel<FileUpload>) ->
> FileUploadField(String, ListModel<FileUpload>)
>
> The last one seems unnecessary: we already have a
> MultiFileUploadField, why not use that one instead? If someone uses a
> singular FileUpload together with multiple, just throw an exception
> and tell them to use MultiFileUpload instead.

Because MultiFileUploadField has totally different implementation than
FileUploadField.
HTML5 added 'multiple' to <input type="file">. The support for it in
FUF was straight forward. So I just added it.
Now FUF has #getFileUploads() and the backward compatible
#getFileUpload() which justs does  #getFileUploads()(0) in null-safe
manner.

There were two tickets about this. They are in the changelog.

>
> Martijn
>
> On Fri, Jun 17, 2011 at 10:08 AM, Martin Grigorov <mg...@apache.org> wrote:
>> +1 to release
>>
>> tested fully wicket-examples before the build
>> tested random apps in wicket-examples with RC5
>> tested Maven build with RC5
>> tested my app against RC5
>>
>> No issues found.
>>
>> On Fri, Jun 17, 2011 at 4:01 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> Erm ends june 19th
>>> On Jun 16, 2011 4:34 PM, "Igor Vaynberg" <ig...@gmail.com> wrote:
>>>> This vote is to release wicket 1.5-RC5
>>>>
>>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>>> Maven repo:
>>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>>> Changelog:
>>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>>
>>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>>
>>>> Please test the release and offer your vote.
>>>>
>>>> The Wicket team!
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: [vote] release 1.5-RC5

Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Jun 17, 2011 at 3:28 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Upgrading from 1.5-RC4.2 to RC5 gives the following API changes...
>
>  - DummyRequestLogger -> RequestLogger
>  - PersistentPageManager -> PageStoreManager
>  - Application#getPageManager() -> Session#getPageManager()
>
For the record Application#setExceptionMapperProvider() is also
removed. I.e. an API break.
IRequestCycleListener#onException() should be used instead.

We changed those now to not keep them "broken" until the next version
where we can make API breaks.

For all these there are tickets which are listed in the changelog.

>  - FileUploadField#FileUploadField(String, IModel<FileUpload>) ->
> FileUploadField(String, ListModel<FileUpload>)
>
> The last one seems unnecessary: we already have a
> MultiFileUploadField, why not use that one instead? If someone uses a
> singular FileUpload together with multiple, just throw an exception
> and tell them to use MultiFileUpload instead.
>
> Martijn
>
> On Fri, Jun 17, 2011 at 10:08 AM, Martin Grigorov <mg...@apache.org> wrote:
>> +1 to release
>>
>> tested fully wicket-examples before the build
>> tested random apps in wicket-examples with RC5
>> tested Maven build with RC5
>> tested my app against RC5
>>
>> No issues found.
>>
>> On Fri, Jun 17, 2011 at 4:01 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> Erm ends june 19th
>>> On Jun 16, 2011 4:34 PM, "Igor Vaynberg" <ig...@gmail.com> wrote:
>>>> This vote is to release wicket 1.5-RC5
>>>>
>>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>>> Maven repo:
>>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>>> Changelog:
>>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>>
>>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>>
>>>> Please test the release and offer your vote.
>>>>
>>>> The Wicket team!
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: [vote] release 1.5-RC5

Posted by Martijn Dashorst <ma...@gmail.com>.
Upgrading from 1.5-RC4.2 to RC5 gives the following API changes...

 - DummyRequestLogger -> RequestLogger
 - PersistentPageManager -> PageStoreManager
 - Application#getPageManager() -> Session#getPageManager()

 - FileUploadField#FileUploadField(String, IModel<FileUpload>) ->
FileUploadField(String, ListModel<FileUpload>)

The last one seems unnecessary: we already have a
MultiFileUploadField, why not use that one instead? If someone uses a
singular FileUpload together with multiple, just throw an exception
and tell them to use MultiFileUpload instead.

Martijn

On Fri, Jun 17, 2011 at 10:08 AM, Martin Grigorov <mg...@apache.org> wrote:
> +1 to release
>
> tested fully wicket-examples before the build
> tested random apps in wicket-examples with RC5
> tested Maven build with RC5
> tested my app against RC5
>
> No issues found.
>
> On Fri, Jun 17, 2011 at 4:01 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> Erm ends june 19th
>> On Jun 16, 2011 4:34 PM, "Igor Vaynberg" <ig...@gmail.com> wrote:
>>> This vote is to release wicket 1.5-RC5
>>>
>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>> Maven repo:
>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>> Changelog:
>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>
>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>
>>> Please test the release and offer your vote.
>>>
>>> The Wicket team!
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: [vote] release 1.5-RC5

Posted by Martin Grigorov <mg...@apache.org>.
+1 to release

tested fully wicket-examples before the build
tested random apps in wicket-examples with RC5
tested Maven build with RC5
tested my app against RC5

No issues found.

On Fri, Jun 17, 2011 at 4:01 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> Erm ends june 19th
> On Jun 16, 2011 4:34 PM, "Igor Vaynberg" <ig...@gmail.com> wrote:
>> This vote is to release wicket 1.5-RC5
>>
>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>> Maven repo:
>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>> Changelog:
>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>
>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>
>> Please test the release and offer your vote.
>>
>> The Wicket team!
>



-- 
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com

Re: [vote] release 1.5-RC5

Posted by Igor Vaynberg <ig...@gmail.com>.
Erm ends june 19th
On Jun 16, 2011 4:34 PM, "Igor Vaynberg" <ig...@gmail.com> wrote:
> This vote is to release wicket 1.5-RC5
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-022/
> Changelog:
>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>
> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team!

Re: [vote] release 1.5-RC5

Posted by Martijn Dashorst <ma...@gmail.com>.
On Sun, Jun 19, 2011 at 9:47 AM, Juergen Donnerstag
<ju...@gmail.com> wrote:
> I fixed it by "reverting" 2874, but providing the functionality as an
> easy to use utility.
>
> Conditional Comments will be ready next.
>

I've updated my workspace and the problem is gone. Thanks!

Martijn

Re: [vote] release 1.5-RC5

Posted by Juergen Donnerstag <ju...@gmail.com>.
I fixed it by "reverting" 2874, but providing the functionality as an
easy to use utility.

Conditional Comments will be ready next.

Juergen

On Fri, Jun 17, 2011 at 7:39 PM, Martijn Dashorst
<ma...@gmail.com> wrote:
> Those are gone except for the xmlns:wicket attributes
>
> Martijn
>
> On Friday, June 17, 2011, Igor Vaynberg <ig...@gmail.com> wrote:
>> setStripWicketTags(true) doesnt work in your app? so your deployed
>> version contains wicket:panel and other tags in final html?
>>
>> -igor
>>
>> On Fri, Jun 17, 2011 at 9:36 AM, Martijn Dashorst
>> <ma...@gmail.com> wrote:
>>> -1
>>>
>>> When rendering any page, I suddenly get
>>> xmlns:wicket="http://wicket.apache.org" for each panel that is
>>> included. This is invalid XHTML markup and fails each request in our
>>> application (we use a markup validator that validates each and every
>>> page). This is a regression from 1.5-RC4.2
>>>
>>> I have a test case that proves this
>>> (https://issues.apache.org/jira/browse/WICKET-3812).
>>>
>>> In the test case the issue seems to be resolvable using
>>> setStripWicketTags(true), but that doesn't work in our application
>>> apparently.
>>>
>>> Martijn
>>>
>>> On Fri, Jun 17, 2011 at 3:27 PM, Pedro Santos <pe...@gmail.com> wrote:
>>>> +1
>>>>
>>>> On Thu, Jun 16, 2011 at 8:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>>>> This vote is to release wicket 1.5-RC5
>>>>>
>>>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>>>> Maven repo:
>>>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>>>> Changelog:
>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>>>
>>>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>>>
>>>>> Please test the release and offer your vote.
>>>>>
>>>>> The Wicket team!
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Pedro Henrique Oliveira dos Santos
>>>>
>>>
>>>
>>>
>>> --
>>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>>
>>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: [vote] release 1.5-RC5

Posted by Martijn Dashorst <ma...@gmail.com>.
Those are gone except for the xmlns:wicket attributes

Martijn

On Friday, June 17, 2011, Igor Vaynberg <ig...@gmail.com> wrote:
> setStripWicketTags(true) doesnt work in your app? so your deployed
> version contains wicket:panel and other tags in final html?
>
> -igor
>
> On Fri, Jun 17, 2011 at 9:36 AM, Martijn Dashorst
> <ma...@gmail.com> wrote:
>> -1
>>
>> When rendering any page, I suddenly get
>> xmlns:wicket="http://wicket.apache.org" for each panel that is
>> included. This is invalid XHTML markup and fails each request in our
>> application (we use a markup validator that validates each and every
>> page). This is a regression from 1.5-RC4.2
>>
>> I have a test case that proves this
>> (https://issues.apache.org/jira/browse/WICKET-3812).
>>
>> In the test case the issue seems to be resolvable using
>> setStripWicketTags(true), but that doesn't work in our application
>> apparently.
>>
>> Martijn
>>
>> On Fri, Jun 17, 2011 at 3:27 PM, Pedro Santos <pe...@gmail.com> wrote:
>>> +1
>>>
>>> On Thu, Jun 16, 2011 at 8:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>>> This vote is to release wicket 1.5-RC5
>>>>
>>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>>> Maven repo:
>>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>>> Changelog:
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>>
>>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>>
>>>> Please test the release and offer your vote.
>>>>
>>>> The Wicket team!
>>>>
>>>
>>>
>>>
>>> --
>>> Pedro Henrique Oliveira dos Santos
>>>
>>
>>
>>
>> --
>> Become a Wicket expert, learn from the best: http://wicketinaction.com
>>
>

-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: [vote] release 1.5-RC5

Posted by Igor Vaynberg <ig...@gmail.com>.
setStripWicketTags(true) doesnt work in your app? so your deployed
version contains wicket:panel and other tags in final html?

-igor

On Fri, Jun 17, 2011 at 9:36 AM, Martijn Dashorst
<ma...@gmail.com> wrote:
> -1
>
> When rendering any page, I suddenly get
> xmlns:wicket="http://wicket.apache.org" for each panel that is
> included. This is invalid XHTML markup and fails each request in our
> application (we use a markup validator that validates each and every
> page). This is a regression from 1.5-RC4.2
>
> I have a test case that proves this
> (https://issues.apache.org/jira/browse/WICKET-3812).
>
> In the test case the issue seems to be resolvable using
> setStripWicketTags(true), but that doesn't work in our application
> apparently.
>
> Martijn
>
> On Fri, Jun 17, 2011 at 3:27 PM, Pedro Santos <pe...@gmail.com> wrote:
>> +1
>>
>> On Thu, Jun 16, 2011 at 8:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> This vote is to release wicket 1.5-RC5
>>>
>>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>>> Maven repo:
>>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>>> Changelog:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>>
>>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>>
>>> Please test the release and offer your vote.
>>>
>>> The Wicket team!
>>>
>>
>>
>>
>> --
>> Pedro Henrique Oliveira dos Santos
>>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>

Re: [vote] release 1.5-RC5

Posted by Martijn Dashorst <ma...@gmail.com>.
-1

When rendering any page, I suddenly get
xmlns:wicket="http://wicket.apache.org" for each panel that is
included. This is invalid XHTML markup and fails each request in our
application (we use a markup validator that validates each and every
page). This is a regression from 1.5-RC4.2

I have a test case that proves this
(https://issues.apache.org/jira/browse/WICKET-3812).

In the test case the issue seems to be resolvable using
setStripWicketTags(true), but that doesn't work in our application
apparently.

Martijn

On Fri, Jun 17, 2011 at 3:27 PM, Pedro Santos <pe...@gmail.com> wrote:
> +1
>
> On Thu, Jun 16, 2011 at 8:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>> This vote is to release wicket 1.5-RC5
>>
>> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
>> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
>> Maven repo:
>> https://repository.apache.org/content/repositories/orgapachewicket-022/
>> Changelog:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>>
>> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>>
>> Please test the release and offer your vote.
>>
>> The Wicket team!
>>
>
>
>
> --
> Pedro Henrique Oliveira dos Santos
>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com

Re: [vote] release 1.5-RC5

Posted by Pedro Santos <pe...@gmail.com>.
+1

On Thu, Jun 16, 2011 at 8:34 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> This vote is to release wicket 1.5-RC5
>
> Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC5/
> Artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC5/dist/
> Maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-022/
> Changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&version=12316423
>
> This vote ends Thursday, March 19st at 5:00pm (GMT-8)
>
> Please test the release and offer your vote.
>
> The Wicket team!
>



-- 
Pedro Henrique Oliveira dos Santos