[GitHub] [iceberg] gaborkaszab commented on a diff in pull request #5792: API,Core: Add scan planning metrics for scanned/skipped delete manifests

[GitBox <gi...@apache.org>]

gaborkaszab commented on code in PR #5792:
URL: https://github.com/apache/iceberg/pull/5792#discussion_r975513880


##########
core/src/test/java/org/apache/iceberg/metrics/TestScanMetricsResultParser.java:
##########
@@ -61,15 +64,39 @@ public void missingFields() {
                 "{\"total-planning-duration\":{\"count\":3,\"time-unit\":\"hours\",\"total-duration\":10}}"))
         .isEqualTo(
             new ScanMetricsResult(
-                totalPlanningDuration, null, null, null, null, null, null, null, null));
+                totalPlanningDuration,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,
+                null,

Review Comment:
   It's just loosely related but as the number of metrics grow this constructor gets longer and longer. Would it make sense to have a ScanMetricsResultBuilder that has a with...() function to set its fields?
   
   If it makes sense I can give it a try to implement that in a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org