You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/06/09 10:31:36 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #215: Improvements in validation of node properties (displaying Issues)
algairim opened a new pull request #215:
URL: https://github.com/apache/brooklyn-ui/pull/215
Add ID field to Issues model to distinguish issues for multiple properties with the same name
Signed-off-by: Mykola Mandra <my...@cloudsoftcorp.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #215: WIP Improvements in validation of node properties (displaying Issues)
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #215:
URL: https://github.com/apache/brooklyn-ui/pull/215#discussion_r648188403
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -483,20 +483,23 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
$state.go(graphicalState.name);
};
- specEditor.getParameterIssues = () => {
- return scope.model.issues
- .filter((issue) => (issue.group === 'parameters'))
- .concat(Object.values(scope.model.getClusterMemberspecEntities())
- .filter((spec) => (spec && spec.hasIssues()))
- .reduce((acc, spec) => (acc.concat(spec.issues)), []));
- };
- scope.getConfigIssues = specEditor.getConfigIssues = () => {
+ /**
+ * Gets collection of issues filtered by group.
+ *
+ * @param {String} groupName The group name to filter issues by.
+ * @returns {[]} The collection of issues found.
+ */
+ scope.getIssuesByGroup = (groupName) => {
Review comment:
This is just a refactoring, now this method can be used to get issues for any relevant group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit closed pull request #215: Improvements in validation of node properties (displaying Issues)
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #215:
URL: https://github.com/apache/brooklyn-ui/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit merged pull request #215: Improvements in validation of node properties (displaying Issues)
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #215:
URL: https://github.com/apache/brooklyn-ui/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #215: WIP Improvements in validation of node properties (displaying Issues)
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #215:
URL: https://github.com/apache/brooklyn-ui/pull/215#issuecomment-857599543
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org