You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/02/27 01:07:17 UTC
Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for shell
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
test/pom.xml 1e88b34a684709e7a0ad8a71480e7bad37a94398
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml c03fb4f008ec75a65efbd6ad6c4eb33d37099124
Diff: https://reviews.apache.org/r/44115/diff/
Testing
-------
yes
Thanks,
Abraham Fine
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/#review121804
-----------------------------------------------------------
Ship it!
Ship It!
- Dian Fu
On March 3, 2016, 5:20 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44115/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5:20 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2844
> https://issues.apache.org/jira/browse/SQOOP-2844
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2844: Sqoop2: TrustStore support for shell
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
> shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
> shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
> shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
> shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 9e1c68305ea9fd678a085d7035ad2bf6311802eb
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
>
> Diff: https://reviews.apache.org/r/44115/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
(Updated March 8, 2016, 6:25 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 4696a8764420075bb6f7659b41f9fe81e59f7d8a
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 80ac935e3992c1c5e977a6d06abb6f049ba7d423
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
Diff: https://reviews.apache.org/r/44115/diff/
Testing
-------
yes.
Thanks,
Abraham Fine
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
(Updated March 7, 2016, 11:32 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 4696a8764420075bb6f7659b41f9fe81e59f7d8a
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 80ac935e3992c1c5e977a6d06abb6f049ba7d423
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
Diff: https://reviews.apache.org/r/44115/diff/
Testing
-------
yes.
Thanks,
Abraham Fine
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
(Updated March 3, 2016, 5:20 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 9e1c68305ea9fd678a085d7035ad2bf6311802eb
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
Diff: https://reviews.apache.org/r/44115/diff/
Testing
-------
yes.
Thanks,
Abraham Fine
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
> On March 3, 2016, 2:05 a.m., Dian Fu wrote:
> > shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java, line 20
> > <https://reviews.apache.org/r/44115/diff/2/?file=1274723#file1274723line20>
> >
> > This import is unused.
thanks
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/#review121755
-----------------------------------------------------------
On March 3, 2016, 5:20 a.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44115/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5:20 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2844
> https://issues.apache.org/jira/browse/SQOOP-2844
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2844: Sqoop2: TrustStore support for shell
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
> shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
> shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
> shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
> shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 9e1c68305ea9fd678a085d7035ad2bf6311802eb
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
>
> Diff: https://reviews.apache.org/r/44115/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/#review121755
-----------------------------------------------------------
Thanks a lot for this work, Abe! A few comments as follows:
1. This JIRA add truststore at client side which makes it possible for client to specify the server it trusts. Is it also unnecessary to add a truststore at server side to let server specify the clients it trusts?
2. If #1 makes sense, then it's necessary to add keystore at client side. (This JIRA only makes it possible to specify the truststore at client side)
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java (line 20)
<https://reviews.apache.org/r/44115/#comment183565>
This import is unused.
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java (line 84)
<https://reviews.apache.org/r/44115/#comment183576>
Variable trustFactory is not used.
- Dian Fu
On Feb. 29, 2016, 10:49 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44115/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 10:49 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2844
> https://issues.apache.org/jira/browse/SQOOP-2844
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> SQOOP-2844: Sqoop2: TrustStore support for shell
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
> shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
> shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
> shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
> shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
> shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
>
> Diff: https://reviews.apache.org/r/44115/diff/
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 10:49 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/utils/ProcessUtils.java PRE-CREATION
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
Diff: https://reviews.apache.org/r/44115/diff/
Testing
-------
yes.
Thanks,
Abraham Fine
Re: Review Request 44115: SQOOP-2844: Sqoop2: TrustStore support for
shell
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44115/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 12:07 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2844
https://issues.apache.org/jira/browse/SQOOP-2844
Repository: sqoop-sqoop2
Description
-------
SQOOP-2844: Sqoop2: TrustStore support for shell
Diffs
-----
core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 6f32e04be6fc47051e7c0cc90a881cb872cb3934
dist/src/main/conf/sqoop.properties 620146d5c8a2f736d5d139e6452b0165cbdfaa17
server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 2c4cb7a13aacd1e4e3222d54fb3b1ef518aa2ebb
server/src/main/java/org/apache/sqoop/server/common/ServerError.java 1b021cf27defee1493ad620466a89b9fae1b5bb5
shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 3feaac3061a8e6008ef021dff8022ea79a2c2ba7
shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java e430f9d13c8d6f7b637c923c3609e072582290b8
shell/src/main/java/org/apache/sqoop/shell/SetTruststoreFunction.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java 36d0712505bd6d87fd7d332897f155f3cfbc5de7
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 8af53f21cb3a8a3555ca25fc65e2b6c5dfca3a2c
shell/src/main/resources/shell-resource.properties 630c31d77a0a96525ef0f3a8ad20b64b5bb24c72
test/pom.xml 1e88b34a684709e7a0ad8a71480e7bad37a94398
test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021
test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 83f960b87987d1c1ed8f0161616e631f63f14543
test/src/main/java/org/apache/sqoop/test/utils/SecurityUtils.java PRE-CREATION
test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java 6614b19932c304aa40500fcaedd974b1b136caec
test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java 7f0575b49c58fcec1c69069f25929411a6c7ba12
test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java 87f0eb1966de4d7ea9b1c37b881cad0ae7a88fa4
test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java a82a4daea607bee4e78bf2a649b7c9d5228448be
test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java PRE-CREATION
test/src/test/resources/connector-loading-tests-suite.xml c03fb4f008ec75a65efbd6ad6c4eb33d37099124
Diff: https://reviews.apache.org/r/44115/diff/
Testing (updated)
-------
yes.
Thanks,
Abraham Fine