You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/13 00:39:12 UTC

[GitHub] [shardingsphere] takuya1981 opened a new pull request #11298: Add unit test for shardingsphere-infra-route #10987

takuya1981 opened a new pull request #11298:
URL: https://github.com/apache/shardingsphere/pull/11298


   Add unit test AllSQLRouteExecutorTest for AllSQLRouteExecutor in shardingsphere-infra-route project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] takuya1981 commented on pull request #11298: Add unit test for shardingsphere-infra-route #10987

Posted by GitBox <gi...@apache.org>.
takuya1981 commented on pull request #11298:
URL: https://github.com/apache/shardingsphere/pull/11298#issuecomment-879474897


   @tristaZero Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero merged pull request #11298: Add unit test for shardingsphere-infra-route #10987

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11298:
URL: https://github.com/apache/shardingsphere/pull/11298


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #11298: Add unit test for shardingsphere-infra-route #10987

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11298:
URL: https://github.com/apache/shardingsphere/pull/11298#issuecomment-878706564


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11298](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (870a4e1) into [master](https://codecov.io/gh/apache/shardingsphere/commit/961d2c1ed89b3a45a2ceb65768d0ba11c9ba4ae6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (961d2c1) will **decrease** coverage by `0.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11298/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11298      +/-   ##
   ============================================
   - Coverage     63.62%   63.37%   -0.25%     
   - Complexity     1024     1027       +3     
   ============================================
     Files          2177     2205      +28     
     Lines         33348    33685     +337     
     Branches       5842     5897      +55     
   ============================================
   + Hits          21216    21348     +132     
   - Misses        10444    10632     +188     
   - Partials       1688     1705      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ere/scaling/distsql/parser/core/ScalingParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9jb3JlL1NjYWxpbmdQYXJzZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...parser/facade/ScalingSQLStatementParserFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9mYWNhZGUvU2NhbGluZ1NRTFN0YXRlbWVudFBhcnNlckZhY2FkZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rameterized/engine/SQLParserParameterizedTest.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvZW5naW5lL1NRTFBhcnNlclBhcmFtZXRlcml6ZWRUZXN0LmphdmE=) | `0.00% <0.00%> (-69.57%)` | :arrow_down: |
   | [...serts/segment/parameter/ParameterMarkerAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zZWdtZW50L3BhcmFtZXRlci9QYXJhbWV0ZXJNYXJrZXJBc3NlcnQuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...config/service/impl/DataSourceRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jb25maWcvc2VydmljZS9pbXBsL0RhdGFTb3VyY2VSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `33.33% <0.00%> (-46.67%)` | :arrow_down: |
   | [.../parameterized/jaxb/sql/loader/SQLCasesLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9zcWwvbG9hZGVyL1NRTENhc2VzTG9hZGVyLmphdmE=) | `16.36% <0.00%> (-45.07%)` | :arrow_down: |
   | [...eterized/asserts/statement/SQLStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvU1FMU3RhdGVtZW50QXNzZXJ0LmphdmE=) | `0.00% <0.00%> (-31.25%)` | :arrow_down: |
   | [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `22.22% <0.00%> (-29.63%)` | :arrow_down: |
   | [...config/service/impl/SchemaRuleRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jb25maWcvc2VydmljZS9pbXBsL1NjaGVtYVJ1bGVSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `36.84% <0.00%> (-25.07%)` | :arrow_down: |
   | [...istsql/parser/core/ScalingSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpc3RzcWwvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9kaXN0c3FsL3BhcnNlci9jb3JlL1NjYWxpbmdTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
   | ... and [112 more](https://codecov.io/gh/apache/shardingsphere/pull/11298/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [961d2c1...870a4e1](https://codecov.io/gh/apache/shardingsphere/pull/11298?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org