You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 10:32:31 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`

RaigorJiang opened a new issue, #21460:
URL: https://github.com/apache/shardingsphere/issues/21460

   ### Background
   
   `SET READWRITE_SPLITTING HINT SOURCE = [auto / write]` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `SetReadwriteSplittingHintStatement`. Now we need to add a test case for this parsing process to assert that the parsing is correct.
   
   
   ### Aim
   
   Add SQL parser test case for `SetReadwriteSplittingHintStatement`.
   
   - Affected files:
   
     - SQLParserTestCases (**modify**)
   
     - test/parser/src/main/resources/case/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/resources/sql/supported/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/SetReadwriteSplittingHintStatementTestCase.java (**create**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/updatable/SetReadwriteSplittingHintStatementAssert.java (**create**)
   
     - UpdatableRALStatementAssert (**modify**)
   
   
   - After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
   
   ### Basic Qualifications
   
   - Java
   - Maven
   
   
   ### Example FYI
   
   - ImportDatabaseConfigurationStatement
   - ImportDatabaseConfigurationStatementTestCase
   - ImportDatabaseConfigurationStatementAssert
   - SQLParserTestCases
   - search for "import-database-config"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`
URL: https://github.com/apache/shardingsphere/issues/21460


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21460:
URL: https://github.com/apache/shardingsphere/issues/21460#issuecomment-1316813663

   > Close this pr due to pr being merged.
   
   Yes, thank you! @isHuangXin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin commented on issue #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`

Posted by GitBox <gi...@apache.org>.
isHuangXin commented on issue #21460:
URL: https://github.com/apache/shardingsphere/issues/21460#issuecomment-1316455959

   Close this pr due to pr being merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] isHuangXin commented on issue #21460: [DistSQL] Add SQL parser test case for `SetReadwriteSplittingHintStatement`

Posted by GitBox <gi...@apache.org>.
isHuangXin commented on issue #21460:
URL: https://github.com/apache/shardingsphere/issues/21460#issuecomment-1313049544

   [WeOpen Star] Hi, Jiang. I want to try this issue. Plz assign it to me~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org