You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/04/08 21:48:54 UTC

[GitHub] couchdb pull request: COUCHDB-2125 Sort tasks

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/204

    COUCHDB-2125 Sort tasks

    This might need some styling / concept love and I hope I understood the comments in the ticket.
    
    This PR includes a heavy refactor, which is also a separate PR #203 which can get merged earlier without a discussion regarding the concept and design, and I will update this PR as the other PR changes.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 2125-sort-tasks-feature

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #204
    
----
commit 75f9a04e116fcee353e1d81dd61ff69867d868f5
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-04-06T16:17:36Z

    Fauxton: reformat code & remove whitespace

commit 887f004ffbbb1ff04d2e7f686f17b0068228367c
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-04-06T21:15:16Z

    Fauxton: refactor ActiveTasks
    
    - do not use a model as a collection, directly operate on the
      collection which gets filtered for the view
    - remove the view which acted as layer to fetch collections from
      the model and passed it to a view
    - remove not used html-template
    - format code

commit 7090bd51863f9be2bb588a399274a534946dff1a
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-04-06T21:42:04Z

    Fauxton: do not load unnessecary d3 & backbone

commit b8dc9958108dadfa9e81596333117e4424f6648a
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-04-08T19:26:47Z

    Fauxton: Add sorting buttons
    
    Fixes COUCHDB-2125

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: COUCHDB-2125 Sort tasks

Posted by deathbearbrown <gi...@git.apache.org>.

Github user deathbearbrown commented on the pull request:

    https://github.com/apache/couchdb/pull/204#issuecomment-40401935
  
    Ok I checked this out and looked at it. I wanted something more like a sortable table, than a sidebar with sort options.  Like this:
    http://tablesorter.com/docs/
    
    You can use a plugin, or create a sortable table component that has click events on the headers and will sort a collection based on the value of a data attribute attached to the header.  <-- this is probably what I'd do. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: COUCHDB-2125 Sort tasks

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb/pull/204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: COUCHDB-2125 Sort tasks

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/204#issuecomment-40408062
  
    okay, will go back to the drawing board! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---