You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/02/21 16:44:35 UTC

Review Request: FLUME-982 PolingSourceRunner.PollingRunner should treat an exception like a backoff

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3978/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

If an exception is thrown by a source, we should backoff as it likely means the source is in a worse state then if it was able to return BACKOFF.


This addresses bug FLUME-982.
    https://issues.apache.org/jira/browse/FLUME-982


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 264fce1 

Diff: https://reviews.apache.org/r/3978/diff


Testing
-------

All unit tests pass.


Thanks,

Brock


Re: Review Request: FLUME-982 PollableSourceRunner.PollingRunner should treat an exception like a backoff

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3978/
-----------------------------------------------------------

(Updated 2012-02-28 15:23:36.527595)


Review request for Flume.


Changes
-------

Changed title to match JIRA title change.


Summary (updated)
-------

If an exception is thrown by a source, we should backoff as it likely means the source is in a worse state then if it was able to return BACKOFF.


This addresses bug FLUME-982.
    https://issues.apache.org/jira/browse/FLUME-982


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 264fce1 

Diff: https://reviews.apache.org/r/3978/diff


Testing
-------

All unit tests pass.


Thanks,

Brock


Re: Review Request: FLUME-982 PolingSourceRunner.PollingRunner should treat an exception like a backoff

Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3978/
-----------------------------------------------------------

(Updated 2012-02-28 15:22:35.604041)


Review request for Flume.


Changes
-------

Updating patch as the class was renamed.


Summary
-------

If an exception is thrown by a source, we should backoff as it likely means the source is in a worse state then if it was able to return BACKOFF.


This addresses bug FLUME-982.
    https://issues.apache.org/jira/browse/FLUME-982


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java 264fce1 

Diff: https://reviews.apache.org/r/3978/diff


Testing
-------

All unit tests pass.


Thanks,

Brock