You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/09/22 15:53:08 UTC
[GitHub] [incubator-opendal] tisonkun opened a new pull request, #3161: test: resturcture java behavior tests
tisonkun opened a new pull request, #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3161: test: resturcture java behavior tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161#discussion_r1334933848
##########
bindings/java/src/test/java/org/apache/opendal/behavior/S3Test.java:
##########
Review Comment:
Updated. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3161: test: resturcture java behavior tests
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161#discussion_r1334933212
##########
bindings/java/src/test/java/org/apache/opendal/behavior/S3Test.java:
##########
Review Comment:
> This is possible - we can squash up them into one file or just place into the behavior test.
How about place them into the behavior test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3161: test: resturcture java behavior tests
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161#discussion_r1334932837
##########
bindings/java/src/test/java/org/apache/opendal/behavior/S3Test.java:
##########
Review Comment:
Can we avoid those files? It's better to not maintain such file for every service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #3161: test: resturcture java behavior tests
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3161: test: resturcture java behavior tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161#discussion_r1334933895
##########
bindings/java/src/test/java/org/apache/opendal/behavior/S3Test.java:
##########
Review Comment:
> How about place them into the behavior test?
The test file can be large. Let's follow Java's idiom and try to separate focus as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on a diff in pull request #3161: test: resturcture java behavior tests
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3161:
URL: https://github.com/apache/incubator-opendal/pull/3161#discussion_r1334932968
##########
bindings/java/src/test/java/org/apache/opendal/behavior/S3Test.java:
##########
Review Comment:
This is possible - we can squash up them into one file or just place into the behavior test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org