You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/15 18:00:45 UTC

[GitHub] [iceberg] stevenzwu commented on a change in pull request #3120: Core: read delete files in parallel

stevenzwu commented on a change in pull request #3120:
URL: https://github.com/apache/iceberg/pull/3120#discussion_r709441848



##########
File path: core/src/main/java/org/apache/iceberg/util/ThreadPools.java
##########
@@ -61,6 +61,15 @@ public static ExecutorService getWorkerPool() {
     return WORKER_POOL;
   }
 
+  /**
+   * Return parallelism for "worker" thread-pool.
+   * In default, we submit 2 tasks per worker at a time.
+   * @return the parallelism of the worker pool.
+   */
+  public static int getPoolParallelism() {

Review comment:
       I am wondering if it is better to define a constant as 
   ```
   public static final int DEFAULT_WORKER_THREAD_POOL_PARALLELISM = WORKER_THREAD_POOL_SIZE * 2;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org