[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #358: GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.

[GitBox <gi...@apache.org>]

jmuehlner commented on a change in pull request #358:
URL: https://github.com/apache/guacamole-server/pull/358#discussion_r840956018



##########
File path: src/libguac/user-handlers.c
##########
@@ -676,6 +677,21 @@ int __guac_handshake_image_handler(guac_user* user, int argc, char** argv) {
     
 }
 
+int __guac_handshake_name_handler(guac_user* user, int argc, char** argv) {
+
+    /* Free any past value */
+    free((char *) user->info.name);
+
+    if (argc > 0 && strcmp(argv[0], ""))

Review comment:
       I think this would benefit from a comment describing what this is for, and maybe some more descriptive variable names.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org