You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/10 16:23:10 UTC
[GitHub] [bookkeeper] gaozhangmin opened a new pull request #2790: only update topology when bookie rack changed
gaozhangmin opened a new pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790
It is unnecessary to update topology, removing and adding the same bookieNode, if the rack of bookie stay unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-1016424672
@eolivelli PTAL again, It has been for a lone time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-1016429512
@zymap PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-1084184090
@dlg99 Test added. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-987652655
@eolivelli Could you please take a look at this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin removed a comment on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-917795356
> Can you explain the benefits of this patch?
When using pulsar bookie affinity group, if We update the bookie region info, this logic will update all the bookie info in the topology, including the unchanged bookie. we should only update the bookies which rack has been changed.
I will enhanced the existing unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin edited a comment on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-917795498
> Can you explain the benefits of this patch?
> Do you have some use case or problem?
>
> Adding a test case will help in understanding the problem better
Using pulsar bookie affinity group, when updating some bookie's region and rack info, this logic will update all the bookie info in the topology, including the unchanged bookie. we should only update the bookies which rack has been changed.
I will enhanced the existing unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-917795356
> Can you explain the benefits of this patch?
When using pulsar bookie affinity group, if We update the bookie region info, this logic will update all the bookie info in the topology, including the unchanged bookie. we should only update the bookies which rack has been changed.
I will enhanced the existing unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] gaozhangmin commented on pull request #2790: only update topology when bookie rack changed
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #2790:
URL: https://github.com/apache/bookkeeper/pull/2790#issuecomment-917795498
> Can you explain the benefits of this patch?
> Do you have some use case or problem?
>
> Adding a test case will help in understanding the problem better
When using pulsar bookie affinity group, if We update the bookie region info, this logic will update all the bookie info in the topology, including the unchanged bookie. we should only update the bookies which rack has been changed.
I will enhanced the existing unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org