You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/07/09 04:02:33 UTC

[GitHub] [kylin] zhouyao1994 opened a new pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

zhouyao1994 opened a new pull request #1313:
URL: https://github.com/apache/kylin/pull/1313


   ## Proposed changes
   
   [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [x] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature works
   - [x] If this change need a document change, I will prepare another pr against the `document` branch
   - [x] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] RupengWang commented on pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
RupengWang commented on pull request #1313:
URL: https://github.com/apache/kylin/pull/1313#issuecomment-655911280


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on a change in pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1313:
URL: https://github.com/apache/kylin/pull/1313#discussion_r452037416



##########
File path: README.md
##########
@@ -14,11 +14,37 @@ Apache Kylin
 
 Apache Kylin is an open source Distributed Analytics Engine, contributed by eBay Inc., provides SQL interface and multi-dimensional analysis (OLAP) on Hadoop supporting extremely large datasets.
 
-For more details, see the website [http://kylin.apache.org](http://kylin.apache.org).
+For more details, see the website [http://kylin.apache.org](http://kylin.apache.org), Chinese version:[http://kylin.apache.org/cn/](http://kylin.apache.org/cn/).
+
+Get start kylin in 5 min with Docker
+=============
+In order to allow users to  try Kylin easily, We provide Kylin’s docker image.
+
+Just run codes blow in your terminal. After 3~5 mins, you can access kylin WebUI [http://127.0.0.1:7070/kylin/login](http://127.0.0.1:7070/kylin/login) in your browser.

Review comment:
       Typo, should be "below" .

##########
File path: README.md
##########
@@ -14,11 +14,37 @@ Apache Kylin
 
 Apache Kylin is an open source Distributed Analytics Engine, contributed by eBay Inc., provides SQL interface and multi-dimensional analysis (OLAP) on Hadoop supporting extremely large datasets.
 
-For more details, see the website [http://kylin.apache.org](http://kylin.apache.org).
+For more details, see the website [http://kylin.apache.org](http://kylin.apache.org), Chinese version:[http://kylin.apache.org/cn/](http://kylin.apache.org/cn/).
+
+Get start kylin in 5 min with Docker
+=============
+In order to allow users to  try Kylin easily, We provide Kylin’s docker image.

Review comment:
       lowercase the word "We" 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1313:
URL: https://github.com/apache/kylin/pull/1313#issuecomment-657326773


   LGTM
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1313:
URL: https://github.com/apache/kylin/pull/1313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhouyao1994 commented on a change in pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
zhouyao1994 commented on a change in pull request #1313:
URL: https://github.com/apache/kylin/pull/1313#discussion_r452094267



##########
File path: README.md
##########
@@ -14,11 +14,37 @@ Apache Kylin
 
 Apache Kylin is an open source Distributed Analytics Engine, contributed by eBay Inc., provides SQL interface and multi-dimensional analysis (OLAP) on Hadoop supporting extremely large datasets.
 
-For more details, see the website [http://kylin.apache.org](http://kylin.apache.org).
+For more details, see the website [http://kylin.apache.org](http://kylin.apache.org), Chinese version:[http://kylin.apache.org/cn/](http://kylin.apache.org/cn/).
+
+Get start kylin in 5 min with Docker
+=============
+In order to allow users to  try Kylin easily, We provide Kylin’s docker image.
+
+Just run codes blow in your terminal. After 3~5 mins, you can access kylin WebUI [http://127.0.0.1:7070/kylin/login](http://127.0.0.1:7070/kylin/login) in your browser.

Review comment:
       thx

##########
File path: README.md
##########
@@ -14,11 +14,37 @@ Apache Kylin
 
 Apache Kylin is an open source Distributed Analytics Engine, contributed by eBay Inc., provides SQL interface and multi-dimensional analysis (OLAP) on Hadoop supporting extremely large datasets.
 
-For more details, see the website [http://kylin.apache.org](http://kylin.apache.org).
+For more details, see the website [http://kylin.apache.org](http://kylin.apache.org), Chinese version:[http://kylin.apache.org/cn/](http://kylin.apache.org/cn/).
+
+Get start kylin in 5 min with Docker
+=============
+In order to allow users to  try Kylin easily, We provide Kylin’s docker image.

Review comment:
       thx




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1313: [KYLIN-4627] Add the document about try kylin with docker to help users to try kylin easily

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1313:
URL: https://github.com/apache/kylin/pull/1313#issuecomment-655914336


   ## Pull Request Test Coverage Report for [Build 6121](https://coveralls.io/builds/31957779)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **14** unchanged lines in **5** files lost coverage.
   * Overall coverage decreased (**-0.007%**) to **28.051%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/31957779/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/31957779/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/31957779/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   | [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/31957779/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 3 | 77.78% |
   | [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/31957779/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 5 | 66.67% |
   <!-- | **Total:** | **14** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/31957779/badge)](https://coveralls.io/builds/31957779) |
   | :-- | --: |
   | Change from base [Build 6117](https://coveralls.io/builds/31940525): |  -0.007% |
   | Covered Lines: | 26218 |
   | Relevant Lines: | 93464 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org