[jira] [Resolved] (YUNIKORN-1164) Fix inconsistent lock behavior in application.go

["Craig Condit (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Condit resolved YUNIKORN-1164.
------------------------------------
    Fix Version/s: 1.0.0
       Resolution: Fixed

Merged to master.

> Fix inconsistent lock behavior in application.go
> ------------------------------------------------
>
>                 Key: YUNIKORN-1164
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1164
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>            Reporter: Craig Condit
>            Assignee: Craig Condit
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>
> The {{Application}} object in {{pkg/scheduler/objects/application.go}} has inconsistent locking in several places:
>  * {{getPlaceholderAllocations()}} accesses the allocations map unlocked which might cause issues.
>  * Usages of {{clearStateTimer()}} also should be checked.
>  * {{HandleApplicationEvent()}} and {{OnStateChange()}} assume the lock is held. However, {{timeoutStateTimer()}} calls {{HandleApplicationEvent()}} with no lock held.
> We should look for any other potential issues here as well.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org