You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by aertoria <gi...@git.apache.org> on 2015/10/12 23:41:17 UTC
[GitHub] spark pull request: Comment Syntax checkup
GitHub user aertoria opened a pull request:
https://github.com/apache/spark/pull/9080
Comment Syntax checkup
Comment Syntax checkup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aertoria/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9080
----
commit ca60f33d5441c3581cc741bdee43d1f87b342d3a
Author: Ethan <ca...@gmail.com>
Date: 2015-10-12T21:39:41Z
Comment Syntax checkup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Comment Syntax checkup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9080#issuecomment-147529751
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Comment Syntax checkup
Posted by aertoria <gi...@git.apache.org>.
Github user aertoria closed the pull request at:
https://github.com/apache/spark/pull/9080
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Comment Syntax checkup
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9080#issuecomment-147601831
Do you mind closing this PR? yes, the text was correct before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Comment Syntax checkup
Posted by aertoria <gi...@git.apache.org>.
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/spark/pull/9080#discussion_r41805641
--- Diff: python/pyspark/context.py ---
@@ -254,7 +253,7 @@ def _ensure_initialized(cls, instance=None, gateway=None):
def __getnewargs__(self):
# This method is called when attempting to pickle SparkContext, which is always an error:
raise Exception(
- "It appears that you are attempting to reference SparkContext from a broadcast "
--- End diff --
Oh it may just failed my comments grammar checker once I loaded to my dev env.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Comment Syntax checkup
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9080#discussion_r41804685
--- Diff: python/pyspark/context.py ---
@@ -254,7 +253,7 @@ def _ensure_initialized(cls, instance=None, gateway=None):
def __getnewargs__(self):
# This method is called when attempting to pickle SparkContext, which is always an error:
raise Exception(
- "It appears that you are attempting to reference SparkContext from a broadcast "
--- End diff --
I think that the old text was correct, no? Did you mean to suggest "refer _to_" instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org