You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ad...@apache.org on 2017/09/20 20:31:57 UTC

[2/5] james-project git commit: JAMES-2145 Remove unneeded *final* qualifiers from TestMailboxSessionMapperFactory

JAMES-2145 Remove unneeded *final* qualifiers from TestMailboxSessionMapperFactory


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/de5e7fc5
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/de5e7fc5
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/de5e7fc5

Branch: refs/heads/master
Commit: de5e7fc5f6c2aaa31f89065a81fa6e1089ced604
Parents: 11842e0
Author: benwa <bt...@linagora.com>
Authored: Tue Sep 19 11:15:09 2017 +0700
Committer: Antoine Duprat <ad...@linagora.com>
Committed: Wed Sep 20 16:18:39 2017 +0200

----------------------------------------------------------------------
 .../store/TestMailboxSessionMapperFactory.java    | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/de5e7fc5/mailbox/store/src/test/java/org/apache/james/mailbox/store/TestMailboxSessionMapperFactory.java
----------------------------------------------------------------------
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/TestMailboxSessionMapperFactory.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/TestMailboxSessionMapperFactory.java
index 5a3937c..e187de0 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/TestMailboxSessionMapperFactory.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/TestMailboxSessionMapperFactory.java
@@ -161,14 +161,14 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
         messageIdMapper = new MessageIdMapper() {
 
             @Override
-            public List<MailboxMessage> find(final Collection<MessageId> messageIds, MessageMapper.FetchType fetchType) {
+            public List<MailboxMessage> find(Collection<MessageId> messageIds, MessageMapper.FetchType fetchType) {
                 return messages.stream()
                     .filter(withMessageIdOneOf(messageIds))
                     .collect(Guavate.toImmutableList());
             }
 
             @Override
-            public List<MailboxId> findMailboxes(final MessageId messageId) {
+            public List<MailboxId> findMailboxes(MessageId messageId) {
                 return messages.stream()
                     .filter(withMessageId(messageId))
                     .map(MailboxMessage::getMailboxId)
@@ -186,7 +186,7 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
             }
 
             @Override
-            public void delete(final MessageId messageId) {
+            public void delete(MessageId messageId) {
                 messages.removeAll(
                     messages.stream()
                         .filter(withMessageId(messageId))
@@ -194,7 +194,7 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
             }
 
             @Override
-            public void delete(final MessageId messageId, final List<MailboxId> mailboxIds) {
+            public void delete(MessageId messageId, List<MailboxId> mailboxIds) {
                 messages.removeAll(
                     messages.stream()
                         .filter(withMessageId(messageId))
@@ -204,7 +204,7 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
 
             @Override
             public Map<MailboxId, UpdatedFlags> setFlags(MessageId messageId, List<MailboxId> mailboxIds, Flags newState, MessageManager.FlagsUpdateMode updateMode) throws MailboxException {
-                final List<Map.Entry<MailboxId, UpdatedFlags>> entries = messages.stream()
+                List<Map.Entry<MailboxId, UpdatedFlags>> entries = messages.stream()
                     .filter(withMessageId(messageId))
                     .filter(inMailboxes(mailboxIds))
                     .map(toMapEntryOfUpdatedFlags(newState, updateMode))
@@ -286,15 +286,15 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
         messages.clear();
     }
 
-    private Predicate<MailboxMessage> withMessageIdOneOf(final Collection<MessageId> messageIds) {
+    private Predicate<MailboxMessage> withMessageIdOneOf(Collection<MessageId> messageIds) {
         return mailboxMessage -> messageIds.contains(mailboxMessage.getMessageId());
     }
 
-    private Predicate<MailboxMessage> inMailboxes(final List<MailboxId> mailboxIds) {
+    private Predicate<MailboxMessage> inMailboxes(List<MailboxId> mailboxIds) {
         return mailboxMessage -> mailboxIds.contains(mailboxMessage.getMailboxId());
     }
 
-    private Predicate<MailboxMessage> withMessageId(final MessageId messageId) {
+    private Predicate<MailboxMessage> withMessageId(MessageId messageId) {
         return mailboxMessage -> mailboxMessage.getMessageId().equals(messageId);
     }
 
@@ -302,7 +302,7 @@ public class TestMailboxSessionMapperFactory extends MailboxSessionMapperFactory
         return entry -> entry.getValue().flagsChanged();
     }
 
-    private Function<MailboxMessage, Map.Entry<MailboxId, UpdatedFlags>> toMapEntryOfUpdatedFlags(final Flags newState, final MessageManager.FlagsUpdateMode updateMode) {
+    private Function<MailboxMessage, Map.Entry<MailboxId, UpdatedFlags>> toMapEntryOfUpdatedFlags(Flags newState, MessageManager.FlagsUpdateMode updateMode) {
         return mailboxMessage -> {
             Preconditions.checkState(updateMode.equals(MessageManager.FlagsUpdateMode.ADD));
             return new AbstractMap.SimpleEntry<>(mailboxMessage.getMailboxId(),


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org