You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Suresh Thalamati <su...@gmail.com> on 2005/02/02 03:35:21 UTC
[PATCH] new masters for test failures under jdk15
Following tests are failing when run under JDK15:
derbyall/derbynetmats/derbynetmats.fail:derbynet/callable.java
derbyall/derbynetmats/derbynetmats.fail:derbynet/csPrepStmt.java
derbyall/derbynetmats/derbynetmats.fail:derbynet/prepStmt.java
Example diff:
< cstmt.getBigDecimal(2): 0.000000000000001
30a30
> cstmt.getBigDecimal(2): 1E-15
difference in the output of the tests seems to be because of the
java.math.BigDecimal:: toString() output differences in JDK15 and JDK14.
This patch fixes the test failures by creating new master files for the
above mentioned tests when run under jdk15.
Re: [PATCH] new masters for test failures under jdk15
Posted by Daniel John Debrunner <dj...@debrunners.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Suresh Thalamati wrote:
>
> Following tests are failing when run under JDK15:
> derbyall/derbynetmats/derbynetmats.fail:derbynet/callable.java
> derbyall/derbynetmats/derbynetmats.fail:derbynet/csPrepStmt.java
> derbyall/derbynetmats/derbynetmats.fail:derbynet/prepStmt.java
>
> Example diff:
> < cstmt.getBigDecimal(2): 0.000000000000001
> 30a30
>> cstmt.getBigDecimal(2): 1E-15
>
> difference in the output of the tests seems to be because of the
> java.math.BigDecimal:: toString() output differences in JDK15 and JDK14.
> This patch fixes the test failures by creating new master files for the
> above mentioned tests when run under jdk15.
For future reference it's worth considering if the test can be changed
to remove the need for a vm specific master file. In this case as Jeremy
discovered for the engine a while ago, there is a toPlainString() added
in J2SE 5.0 that matches the old toString() behaviour. [Of course why
Sun changed the behaviour here is an interesing question.] Though in
this case using toPlainString() would have to use reflection until we
decide that requiring a download of J2SE 5.0 to build Derby is ok.
Dan.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFCAG2BIv0S4qsbfuQRAmtYAJ4u2tjg7vLTM6VGEG+FOvCMi6tNpQCg1XCC
M3kvLlKz5iYbVHFslTC5Ruo=
=6NxO
-----END PGP SIGNATURE-----
Re: [PATCH] new masters for test failures under jdk15
Posted by Samuel Andrew McIntyre <fu...@nonintuitive.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Feb 1, 2005, at 6:35 PM, Suresh Thalamati wrote:
> Following tests are failing when run under JDK15:
> derbyall/derbynetmats/derbynetmats.fail:derbynet/callable.java
> derbyall/derbynetmats/derbynetmats.fail:derbynet/csPrepStmt.java
> derbyall/derbynetmats/derbynetmats.fail:derbynet/prepStmt.java
>
> difference in the output of the tests seems to be because of the
> java.math.BigDecimal:: toString() output differences in JDK15 and
> JDK14.
> This patch fixes the test failures by creating new master files for
> the above mentioned tests when run under jdk15.
Committed, revision 149488.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
iD8DBQFCAGr9DfB0XauCH7wRAhBZAJ4m3pqLGnHY6+hVt+dOXRWxVidHfgCfe6JE
UWXeDk2iFhU5K+VwtrLCSU0=
=4zkw
-----END PGP SIGNATURE-----