You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2016/11/24 12:19:30 UTC

[GitHub] nifi pull request #1270: NIFI-2729: testSendSuccessWithProxy timeout in Trav...

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/1270

    NIFI-2729: testSendSuccessWithProxy timeout in Travis

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    
    - Changed AtomicBoolean to CountDownLatch to avoid sleeping thread in
      some test cases
    - Specified less number of threads for Jetty and LittleProxy than
      default to lower resource usage
    - Added try catch for the specific gateway timeout case (504) so that
      test can pass even it happens while it fails with other errors

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-2729

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1270
    
----
commit 0ba284e0a2cecee8073abb466070275223de1de7
Author: Koji Kawamura <ij...@apache.org>
Date:   2016-11-24T12:17:04Z

    NIFI-2729: testSendSuccessWithProxy timeout in Travis
    
    - Changed AtomicBoolean to CountDownLatch to avoid sleeping thread in
      some test cases
    - Specified less number of threads for Jetty and LittleProxy than
      default to lower resource usage
    - Added try catch for the specific gateway timeout case (504) so that
      test can pass even it happens while it fails with other errors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1270: NIFI-2729: testSendSuccessWithProxy timeout in Travis

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1270
  
    Since it happens not every time, it can't guarantee this change eliminates the possibility of timeout failure, but I was able to reproduce the same behavior using JUnit rule to run the suspected test 500 times with 10 threads. Here is the [sample code](https://github.com/ijokarumawak/nifi/commit/ba5be6f3c89deda8197d59d789feb78cf29f277b#diff-d14afc9dcbb637a81d33f6303eab3909R35).
    
    With 500 loops and 10 threads, I got following reproduce rate:
    1. without any change: 10 failures out of 20 attempts: 50%
    2. adding catch 504 (without fix 3): 0 failure out of 10 attempts: 0%
    3. reducing the number of Jetty and LittleProxy threads (without fix 2): 0 failure out of 20 attempts: 0%
    
    I hope the above fix.3 mitigate the timeout failure. Even if it does, fix.2 will catch the exception and let test pass through.
    
    I would like to keep this as Unit test rather than make it as Integration Test. If the change and above test result seem reasonable, please merge this and let it run for a while to see if it actually works as expected.
    
    Thanks!
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1270: NIFI-2729: testSendSuccessWithProxy timeout in Trav...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---