You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/03/02 17:04:05 UTC

[jira] [Commented] (HDFS-7867) Update action param from "start" to "prepare" in rolling upgrade code comment.

    [ https://issues.apache.org/jira/browse/HDFS-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343307#comment-14343307 ] 

Hadoop QA commented on HDFS-7867:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12701867/HDFS-7867.1.patch
  against trunk revision ca1c00b.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9696//console

This message is automatically generated.

> Update action param from "start" to "prepare" in rolling upgrade code comment.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-7867
>                 URL: https://issues.apache.org/jira/browse/HDFS-7867
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>            Priority: Trivial
>         Attachments: HDFS-7867.1.patch
>
>
> In the following  code comment rolling upgrade action "start" should be updated to "prepare"
> DistributedFileSystem.java :
> {noformat}
>  /**
>    * Rolling upgrade: start/finalize/query.
>    */
>   public RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action)
>       throws IOException {
> {noformat}
> ClientProtocol.java :
> {noformat}
>         /**
>    * Rolling upgrade operations.
>    * @param action either query, start or finailze.
>    * @return rolling upgrade information.
>    */
>   @Idempotent
>   public RollingUpgradeInfo rollingUpgrade(RollingUpgradeAction action)
>       throws IOException;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)