You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/15 18:59:55 UTC

[GitHub] [activemq-artemis] sebthom commented on a change in pull request #3492: ARTEMIS-3180 - fix multiple path match case in wildcard address map

sebthom commented on a change in pull request #3492:
URL: https://github.com/apache/activemq-artemis/pull/3492#discussion_r594606336



##########
File path: tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/AddressMapUnitTest.java
##########
@@ -638,7 +638,7 @@ public void testHashA() throws Exception {
       assertFalse(aABCA.matches(aHashA));
       assertFalse(aHashA.matches(aABCA));
 
-      assertEquals(0, countMatchingWildcards(abcaS));
+      assertEquals(1, countMatchingWildcards(abcaS));

Review comment:
       Isn't this test essentially about if "#.a" matches "a.b.c.a"? Which I think it should.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org