You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Narine Kokhlikyan (JIRA)" <ji...@apache.org> on 2016/07/22 05:35:20 UTC
[jira] [Comment Edited] (SPARK-16679) Move `private[sql]` methods in public APIs used for Python/R into a single ‘helper class’
[ https://issues.apache.org/jira/browse/SPARK-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388942#comment-15388942 ]
Narine Kokhlikyan edited comment on SPARK-16679 at 7/22/16 5:34 AM:
--------------------------------------------------------------------
Two R helper methods on scala side are:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2087
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala#L407
Python helper methods are:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2533
Are there any specific python methods which you'd like to move to a helper class ? [~rxin], [~shivaram].
Also, in some cases R helper methods access to private fields in Dataset and RelationalGroupedDataset, when we move those into a helper class we need to find a way to access those fields or find another solution.
cc [~sunrui]
was (Author: narine):
Two R helper methods on scala side are:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2087
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala#L407
Python helper methods are:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala#L2533
Are there any specific python methods which you'd like to move to a helper class ? [~rxin], [~shivaram].
Also, in some cases R helper methods access to private fields in Dataset and RelationalGroupedDataset, when we move those into a helper class we need to find a way to access to those fields or find another solution.
cc [~sunrui]
> Move `private[sql]` methods in public APIs used for Python/R into a single ‘helper class’
> ------------------------------------------------------------------------------------------
>
> Key: SPARK-16679
> URL: https://issues.apache.org/jira/browse/SPARK-16679
> Project: Spark
> Issue Type: Improvement
> Components: SparkR, SQL
> Reporter: Narine Kokhlikyan
> Priority: Minor
>
> Based on our discussions in:
> https://github.com/apache/spark/pull/12836#issuecomment-225403054
> We’d like to move/relocate `private[sql]` methods in public APIs used for Python/R into a single ‘helper class’,
> since these methods are public in java side and are hard to refactor.
> For instance: private[sql] def mapPartitionsInR(…) method in Dataset.scala
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org