You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2023/07/13 16:22:10 UTC

[GitHub] [hudi] Zouxxyy opened a new pull request, #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Zouxxyy opened a new pull request, #9185:
URL: https://github.com/apache/hudi/pull/9185

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy closed pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy closed pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils
URL: https://github.com/apache/hudi/pull/9185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1634619760

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 370d63db733eac2605bb61a20d95e4a86f8db318 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #9185:
URL: https://github.com/apache/hudi/pull/9185#discussion_r1271264081


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestClusteringProcedure.scala:
##########
@@ -695,8 +695,7 @@ class TestClusteringProcedure extends HoodieSparkProcedureTestBase {
            |  type = 'cow',
            |  preCombineField = 'ts',
            |  hoodie.index.type = 'BUCKET',
-           |  hoodie.bucket.index.hash.field = 'id',
-           |  hoodie.datasource.write.recordkey.field = 'id'
+           |  hoodie.bucket.index.hash.field = 'id'

Review Comment:
   Note, no need this, because we add `HoodieOptionConfig.mapSqlOptionsToDataSourceWriteConfigs` for `catalogProperties`, (bug fix)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1647271419

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18793",
       "triggerID" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 7b20e846575cde7d22f401913bad7ceb44052d67 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576) 
   * 84f3536a7fcd514b3615c1ada48aeee89e992151 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18793) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1635200931

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 370d63db733eac2605bb61a20d95e4a86f8db318 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558) 
   * 7b20e846575cde7d22f401913bad7ceb44052d67 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1647495167

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18793",
       "triggerID" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 84f3536a7fcd514b3615c1ada48aeee89e992151 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18793) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9185:
URL: https://github.com/apache/hudi/pull/9185#discussion_r1271731041


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -23,33 +23,41 @@ import org.apache.hudi.avro.model.HoodieClusteringGroup
 import org.apache.hudi.client.SparkRDDWriteClient
 import org.apache.hudi.common.table.{HoodieTableMetaClient, TableSchemaResolver}
 import org.apache.hudi.common.util.StringUtils
+
 import org.apache.spark.SparkException
 import org.apache.spark.api.java.JavaSparkContext
 import org.apache.spark.sql.SparkSession
 import org.apache.spark.sql.catalyst.TableIdentifier
 import org.apache.spark.sql.catalyst.catalog.HoodieCatalogTable
-import org.apache.spark.sql.hudi.HoodieSqlCommonUtils.withSparkConf
+import org.apache.spark.sql.hudi.HoodieOptionConfig
+import org.apache.spark.sql.hudi.HoodieSqlCommonUtils.isHoodieConfigKey
 
-import scala.collection.JavaConverters.{collectionAsScalaIterableConverter, mapAsJavaMapConverter}
+import scala.collection.JavaConverters._

Review Comment:
   avoid to import star(*)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 merged pull request #9185: [HUDI-6583] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9185:
URL: https://github.com/apache/hudi/pull/9185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1635328866

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 7b20e846575cde7d22f401913bad7ceb44052d67 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1634630941

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 370d63db733eac2605bb61a20d95e4a86f8db318 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1647264262

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     }, {
       "hash" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "84f3536a7fcd514b3615c1ada48aeee89e992151",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 7b20e846575cde7d22f401913bad7ceb44052d67 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18576) 
   * 84f3536a7fcd514b3615c1ada48aeee89e992151 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1634841398

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 370d63db733eac2605bb61a20d95e4a86f8db318 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1635171901

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     }, {
       "hash" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558",
       "triggerID" : "370d63db733eac2605bb61a20d95e4a86f8db318",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7b20e846575cde7d22f401913bad7ceb44052d67",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   * 370d63db733eac2605bb61a20d95e4a86f8db318 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18558) 
   * 7b20e846575cde7d22f401913bad7ceb44052d67 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #9185: [MINOR] Fix catalogProperties in HoodieCLIUtils

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9185:
URL: https://github.com/apache/hudi/pull/9185#issuecomment-1634607097

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e996055eeb8124a6b8b5dce55b736424d53d4756",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e996055eeb8124a6b8b5dce55b736424d53d4756 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #9185:
URL: https://github.com/apache/hudi/pull/9185#discussion_r1271264081


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestClusteringProcedure.scala:
##########
@@ -695,8 +695,7 @@ class TestClusteringProcedure extends HoodieSparkProcedureTestBase {
            |  type = 'cow',
            |  preCombineField = 'ts',
            |  hoodie.index.type = 'BUCKET',
-           |  hoodie.bucket.index.hash.field = 'id',
-           |  hoodie.datasource.write.recordkey.field = 'id'
+           |  hoodie.bucket.index.hash.field = 'id'

Review Comment:
   Note, no need this, because we add `HoodieOptionConfig.mapSqlOptionsToDataSourceWriteConfigs` for `catalogProperties`, (bug fix)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] Zouxxyy commented on a diff in pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #9185:
URL: https://github.com/apache/hudi/pull/9185#discussion_r1271264599


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/procedure/TestClusteringProcedure.scala:
##########
@@ -695,8 +695,7 @@ class TestClusteringProcedure extends HoodieSparkProcedureTestBase {
            |  type = 'cow',
            |  preCombineField = 'ts',
            |  hoodie.index.type = 'BUCKET',
-           |  hoodie.bucket.index.hash.field = 'id',
-           |  hoodie.datasource.write.recordkey.field = 'id'

Review Comment:
   Note, no need this, because we add `HoodieOptionConfig.mapSqlOptionsToDataSourceWriteConfigs` for `catalogProperties`, (bug fix)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #9185: [MINOR] Fix HoodieWriteClient confs in HoodieCLIUtils

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9185:
URL: https://github.com/apache/hudi/pull/9185#discussion_r1271730889


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCLIUtils.scala:
##########
@@ -23,33 +23,41 @@ import org.apache.hudi.avro.model.HoodieClusteringGroup
 import org.apache.hudi.client.SparkRDDWriteClient
 import org.apache.hudi.common.table.{HoodieTableMetaClient, TableSchemaResolver}
 import org.apache.hudi.common.util.StringUtils
+
 import org.apache.spark.SparkException
 import org.apache.spark.api.java.JavaSparkContext
 import org.apache.spark.sql.SparkSession
 import org.apache.spark.sql.catalyst.TableIdentifier
 import org.apache.spark.sql.catalyst.catalog.HoodieCatalogTable
-import org.apache.spark.sql.hudi.HoodieSqlCommonUtils.withSparkConf
+import org.apache.spark.sql.hudi.HoodieOptionConfig
+import org.apache.spark.sql.hudi.HoodieSqlCommonUtils.isHoodieConfigKey
 
-import scala.collection.JavaConverters.{collectionAsScalaIterableConverter, mapAsJavaMapConverter}
+import scala.collection.JavaConverters._
 
 object HoodieCLIUtils {
 
   def createHoodieWriteClient(sparkSession: SparkSession,
                               basePath: String,
-                              conf: Map[String, String],
+                              confs: Map[String, String],

Review Comment:
   conf or options



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org