[jira] [Commented] (KAFKA-12638) Remove default implementation of ConsumerRebalanceListener#onPartitionsLost

["Ben Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317601#comment-17317601 ] 

Ben Chen commented on KAFKA-12638:
----------------------------------

Just curious. For such issue tagged with Majority, who can work on it? Especially there's some time constraints. Also do we have some mechanism to earn credits so that someone with enough "credits" can work on certain things?

> Remove default implementation of ConsumerRebalanceListener#onPartitionsLost
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-12638
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12638
>             Project: Kafka
>          Issue Type: Improvement
>          Components: consumer
>            Reporter: A. Sophie Blee-Goldman
>            Priority: Major
>
> When we added the #onPartitionsLost callback to the ConsumerRebalanceListener in KIP-429, we gave it a default implementation that just invoked the existing #onPartitionsRevoked method for backwards compatibility. This is somewhat inconvenient, since we generally want to invoke #onPartitionsLost in order to skip the committing of offsets on revoked partitions, which is exactly what #onPartitionsRevoked does.
> I don't think we can just remove it in 3.0 since we haven't indicated that we "deprecated" the default implementation or logged a warning that we intend to remove the default in a future release (as we did for the RocksDBConfigSetter#close method in Streams, for example). We should try to add such a warning now, so we can remove it in a future release.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)