[GitHub] [incubator-doris] lingbin commented on a change in pull request #2704: Remove resource_info related members from TaskWorkerPool

[GitBox <gi...@apache.org>]

lingbin commented on a change in pull request #2704: Remove resource_info related members from TaskWorkerPool
URL: https://github.com/apache/incubator-doris/pull/2704#discussion_r365508079
 
 

 ##########
 File path: be/src/agent/task_worker_pool.cpp
 ##########
 @@ -211,84 +190,55 @@ void TaskWorkerPool::start() {
 }
 
 void TaskWorkerPool::submit_task(const TAgentTaskRequest& task) {
-    // Submit task to dequeue
-    TTaskType::type task_type = task.task_type;
+    const TTaskType::type task_type = task.task_type;
 
 Review comment:
   `TTaskType::type` is an `enum`, i.e. it is an `int`, so no need to use an reference. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org