You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/11 11:04:42 UTC

[GitHub] [pulsar] BewareMyPower edited a comment on pull request #9548: [Python] Fix nested Map or Array in schema doesn't work

BewareMyPower edited a comment on pull request #9548:
URL: https://github.com/apache/pulsar/pull/9548#issuecomment-777365251


   Now all tests passed, PTAL again @sijie @codelipenghui @eolivelli 
   
   There's a bug in Python2 that was exposed in my tests accidentally and I fixed it in this PR by the way. The bug is that Python2 doesn't differ bytes and string well and has the `unicode` and `str` type. The existed code only checks if the key of map is `str` but it could be `unicode` during deserialization.
   
   In Python3, this bug doesn't exist.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org