[jira] [Commented] (BOOKKEEPER-438) Move ledger id generation out of LedgerManager

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625001#comment-13625001 ] 

Sijie Guo commented on BOOKKEEPER-438:
--------------------------------------

the patch looks good. some minor comments:

1. could you provide setZkLedgerIdGenPath and setLedgerIdGeneratorClass for the two newly added settings?
2. For FlatLedgerManager, it would be better to have a tool to set the starting ledger id to generate as the max ledger id that flat ledger manager already generated. otherwise, it might end up trying creating ledger manager from 0 to max ledger id due to LedgerExists exceptions.

 
                
> Move ledger id generation out of LedgerManager
> ----------------------------------------------
>
>                 Key: BOOKKEEPER-438
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-438
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-server, hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Jiannan Wang
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch, BOOKKEEPER-438.patch
>
>
> Move id generation out of LedgerManager to ensure different ledger manager implementation shared same ledger id space in ZooKeeper, which is necessary for migration between different ledger managers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira