[jira] [Commented] (AIRFLOW-5052) Add the include_deleted parameter to Salesforce Hook

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899712#comment-16899712 ] 

ASF GitHub Bot commented on AIRFLOW-5052:
-----------------------------------------

wmorris75 commented on pull request #5717: [AIRFLOW-5052] Added the include_deleted params to salesforce make_query
URL: https://github.com/apache/airflow/pull/5717
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add the include_deleted parameter to Salesforce Hook
> ----------------------------------------------------
>
>                 Key: AIRFLOW-5052
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5052
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.4, 2.0.0, 1.10.5
>            Reporter: Wayne Morris
>            Assignee: Wayne Morris
>            Priority: Major
>
> At present, the salesforce hook uses the make_query() method to perform query via Salesforce api. The make_query() accepts a query and and uses a wrapper function which calls the query_all() method from simple salesforce to perform the query.
> The deficiency with the use of the query_all() method is that it does not factor the inclusion of deleted records which is an optional parameter in the query_all() method of simple salesforce as shown below:
> ```
> #query_all method in the salesforce hook
> query_all(query)
> #This should be changed to reflect what the simple salesforce query_all() does in the. background as follows
> {color:#ffc66d}query_all{color}({color:#94558d}self{color}{color:#cc7832}, {color}query{color:#cc7832}, {color}include_deleted={color:#cc7832}False, {color}**kwargs):
> ```
> The objective of this ticket is add these parameters to the salesforce hook so that the hook also has the option of including the deleted records from Salesforce in the query.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)