You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/03/14 12:46:43 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1350: [CELEBORN-418][FLINK][FOLLOW UP]Need drop unused bytes
RexXiong opened a new pull request, #1350:
URL: https://github.com/apache/incubator-celeborn/pull/1350
…n task was already failed
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
it's very rare for supplier.get() cause exception, but we need handle that
### Why are the changes needed?
drop bytes when supplier.get encounter exception.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT & TPCDS random kill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1350: [CELEBORN-418][FLINK][FOLLOW UP]Need drop unused bytes
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1350:
URL: https://github.com/apache/incubator-celeborn/pull/1350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1350: [CELEBORN-418][FLINK][FOLLOW UP]Need drop unused bytes
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1350:
URL: https://github.com/apache/incubator-celeborn/pull/1350#issuecomment-1468056319
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1350](https://codecov.io/gh/apache/incubator-celeborn/pull/1350?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0df9efc) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/6f317c77ee1944de0698a835d4185619e2d44ab8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f317c7) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1350 +/- ##
============================================
- Coverage 29.83% 29.83% -0.00%
+ Complexity 917 916 -1
============================================
Files 221 221
Lines 18520 18520
Branches 1982 1982
============================================
- Hits 5524 5523 -1
Misses 12605 12605
- Partials 391 392 +1
```
[see 1 file with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org